From: Jia Zhu <zhujia.zj@bytedance.com>
To: David Howells <dhowells@redhat.com>
Cc: linux-cachefs@redhat.com, linux-erofs@lists.ozlabs.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Xin Yin <yinxin.x@bytedance.com>,
Jingbo Xu <jefflexu@linux.alibaba.com>,
zhujia.zj@bytedance.com
Subject: Re: [External] Re: [PATCH V4 4/5] cachefiles: narrow the scope of triggering EPOLLIN events in ondemand mode
Date: Wed, 29 Mar 2023 16:08:49 +0800 [thread overview]
Message-ID: <2a39ced1-05f1-d696-1905-4ff5199fa41b@bytedance.com> (raw)
In-Reply-To: <133078.1680013145@warthog.procyon.org.uk>
在 2023/3/28 22:19, David Howells 写道:
> Jia Zhu <zhujia.zj@bytedance.com> wrote:
>
>> + if (!xa_empty(xa)) {
>> + xa_lock(xa);
>> + xa_for_each_marked(xa, index, req, CACHEFILES_REQ_NEW) {
>> + if (!cachefiles_ondemand_is_reopening_read(req)) {
>> + mask |= EPOLLIN;
>> + break;
>> + }
>> + }
>> + xa_unlock(xa);
>> + }
>
> I wonder if there's a more efficient way to do this. I guess it depends on
> how many reqs you expect to get in a queue. It might be worth taking the
> rcu_read_lock before calling xa_lock() and holding it over the whole loop.
>
Thanks for the advice, will use rcu_read_lock（unlock） to replace it.
> David
>
prev parent reply other threads:[~2023-03-29 8:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 5:25 [PATCH V4 0/5] Introduce daemon failover mechanism to recover from crashing Jia Zhu
2023-01-11 5:25 ` [PATCH V4 1/5] cachefiles: introduce object ondemand state Jia Zhu
2023-01-11 5:25 ` [PATCH V4 2/5] cachefiles: extract ondemand info field from cachefiles_object Jia Zhu
2023-01-11 5:25 ` [PATCH V4 3/5] cachefiles: resend an open request if the read request's object is closed Jia Zhu
2023-01-11 5:25 ` [PATCH V4 4/5] cachefiles: narrow the scope of triggering EPOLLIN events in ondemand mode Jia Zhu
2023-01-11 5:25 ` [PATCH V4 5/5] cachefiles: add restore command to recover inflight ondemand read requests Jia Zhu
2023-03-28 13:52 ` [PATCH V4 1/5] cachefiles: introduce object ondemand state David Howells
2023-03-29 3:33 ` Jia Zhu
2023-03-28 13:58 ` [PATCH V4 2/5] cachefiles: extract ondemand info field from cachefiles_object David Howells
2023-03-29 5:06 ` Jia Zhu
2023-03-28 14:12 ` [PATCH V4 3/5] cachefiles: resend an open request if the read request's object is closed David Howells
2023-03-29 11:42 ` Jia Zhu
2023-03-28 14:19 ` [PATCH V4 4/5] cachefiles: narrow the scope of triggering EPOLLIN events in ondemand mode David Howells
2023-03-29 8:08 ` Jia Zhu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a39ced1-05f1-d696-1905-4ff5199fa41b@bytedance.com \
--to=zhujia.zj@bytedance.com \
--cc=dhowells@redhat.com \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yinxin.x@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®