From: David Howells <dhowells@redhat.com>
To: Jia Zhu <zhujia.zj@bytedance.com>
Cc: dhowells@redhat.com, linux-cachefs@redhat.com,
linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jingbo Xu <jefflexu@linux.alibaba.com>
Subject: Re: [PATCH V4 2/5] cachefiles: extract ondemand info field from cachefiles_object
Date: Tue, 28 Mar 2023 14:58:28 +0100 [thread overview]
Message-ID: <132137.1680011908@warthog.procyon.org.uk> (raw)
In-Reply-To: <20230111052515.53941-3-zhujia.zj@bytedance.com>
Jia Zhu <zhujia.zj@bytedance.com> wrote:
> @@ -65,10 +71,7 @@ struct cachefiles_object {
> enum cachefiles_content content_info:8; /* Info about content presence */
> unsigned long flags;
> #define CACHEFILES_OBJECT_USING_TMPFILE 0 /* Have an unlinked tmpfile */
> -#ifdef CONFIG_CACHEFILES_ONDEMAND
> - int ondemand_id;
> - enum cachefiles_object_state state;
> -#endif
> + struct cachefiles_ondemand_info *private;
Why is this no longer inside "#ifdef CONFIG_CACHEFILES_ONDEMAND"?
Also, please don't call it "private", but rather something like "ondemand" or
"ondemand_info".
David
next prev parent reply other threads:[~2023-03-28 13:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 5:25 [PATCH V4 0/5] Introduce daemon failover mechanism to recover from crashing Jia Zhu
2023-01-11 5:25 ` [PATCH V4 1/5] cachefiles: introduce object ondemand state Jia Zhu
2023-01-11 5:25 ` [PATCH V4 2/5] cachefiles: extract ondemand info field from cachefiles_object Jia Zhu
2023-01-11 5:25 ` [PATCH V4 3/5] cachefiles: resend an open request if the read request's object is closed Jia Zhu
2023-01-11 5:25 ` [PATCH V4 4/5] cachefiles: narrow the scope of triggering EPOLLIN events in ondemand mode Jia Zhu
2023-01-11 5:25 ` [PATCH V4 5/5] cachefiles: add restore command to recover inflight ondemand read requests Jia Zhu
2023-03-28 13:52 ` [PATCH V4 1/5] cachefiles: introduce object ondemand state David Howells
2023-03-29 3:33 ` Jia Zhu
2023-03-28 13:58 ` David Howells [this message]
2023-03-29 5:06 ` Re: [PATCH V4 2/5] cachefiles: extract ondemand info field from cachefiles_object Jia Zhu
2023-03-28 14:12 ` [PATCH V4 3/5] cachefiles: resend an open request if the read request's object is closed David Howells
2023-03-29 11:42 ` Jia Zhu
2023-03-28 14:19 ` [PATCH V4 4/5] cachefiles: narrow the scope of triggering EPOLLIN events in ondemand mode David Howells
2023-03-29 8:08 ` [External] " Jia Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=132137.1680011908@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhujia.zj@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®