acerhdf: BIOS product mismatch due to whitespace

acerhdf: BIOS product mismatch due to whitespace

[Ian E. Morgan]

Peter,

Having just upgraded my AOA150 to 2.6.32, acerhdf was complaining:

acerhdf: Acer Aspire One Fan driver, v.0.5.18
acerhdf: unknown (unsupported) BIOS version Acer/AOA150
/v0.3310, please report, aborting!

DMI reports the product as "AOA150         " (i.e. 9 spaces after the
6-character model name). This causes the product match to fail, so I
had to use force_product="AOA150".

acerhdf: Acer Aspire One Fan driver, v.0.5.18
acerhdf: forcing BIOS product: AOA150

Then all was happy again. Any chance you could strip leading/trailing
whitespace in the product match to avoid this issue?

-- 
Ian Morgan

Re: acerhdf: BIOS product mismatch due to whitespace

[Peter Feuerer]

Ian E. Morgan writes:

> Peter,
> 
> Having just upgraded my AOA150 to 2.6.32, acerhdf was complaining:
> 
> acerhdf: Acer Aspire One Fan driver, v.0.5.18
> acerhdf: unknown (unsupported) BIOS version Acer/AOA150
> /v0.3310, please report, aborting!
> 
> DMI reports the product as "AOA150         " (i.e. 9 spaces after the
> 6-character model name). This causes the product match to fail, so I
> had to use force_product="AOA150".
> 
> acerhdf: Acer Aspire One Fan driver, v.0.5.18
> acerhdf: forcing BIOS product: AOA150
> 
> Then all was happy again. Any chance you could strip leading/trailing
> whitespace in the product match to avoid this issue?

Hi Ian,

thanks for reporting, will take care about this issue.

kind regards,
--peter

Re: acerhdf: BIOS product mismatch due to whitespace

[Peter Feuerer]

Hi Ian,

Ian E. Morgan writes:
> Having just upgraded my AOA150 to 2.6.32, acerhdf was complaining:
> 
> acerhdf: Acer Aspire One Fan driver, v.0.5.18
> acerhdf: unknown (unsupported) BIOS version Acer/AOA150
> /v0.3310, please report, aborting!
> 
> DMI reports the product as "AOA150         " (i.e. 9 spaces after the
> 6-character model name). This causes the product match to fail, so I
> had to use force_product="AOA150".
> 
> acerhdf: Acer Aspire One Fan driver, v.0.5.18
> acerhdf: forcing BIOS product: AOA150

could you please be so kind and test:
http://piie.net/files/acerhdf_kmod-0.5.22.tar.gz

Thank you!

kind regards,
--peter

Re: acerhdf: BIOS product mismatch due to whitespace

[Ian E. Morgan]

On Sun, Dec 6, 2009 at 09:37, Peter Feuerer <peter@piie.net> wrote:
>
> could you please be so kind and test:
> http://piie.net/files/acerhdf_kmod-0.5.22.tar.gz

Yep, that does the trick nicely. Thanks. Are you submitting that for .32-stable?

-- 
Ian Morgan

Re: acerhdf: BIOS product mismatch due to whitespace

[Peter Feuerer]

Ian E. Morgan writes:

> On Sun, Dec 6, 2009 at 09:37, Peter Feuerer <peter@piie.net> wrote:
>>
>> could you please be so kind and test:
>> http://piie.net/files/acerhdf_kmod-0.5.22.tar.gz
> 
> Yep, that does the trick nicely. Thanks. Are you submitting that for .32-stable?

I'll provide a patch for -mm and I think this patch can be also applied to .32

thanks again for reporting and testing,
--peter