mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: neil.armstrong@linaro.org
To: Avinal Kumar <avinal.xlvii@gmail.com>,
	jessica.zhang@oss.qualcomm.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/panel: panasonic-vvx10f034n00: transition to mipi_dsi wrapped functions
Date: Tue, 6 Jan 2026 09:21:09 +0100	[thread overview]
Message-ID: <2a9f7c54-3669-4f8b-b46b-b7e01712a1b8@linaro.org> (raw)
In-Reply-To: <20251127161337.396531-1-avinal.xlvii@gmail.com>

Hi,

On 11/27/25 17:08, Avinal Kumar wrote:
> Changes the panasonic-vvx10f034n00 panel to multi
> style functions for improved error handling.
> 
> Signed-off-by: Avinal Kumar <avinal.xlvii@gmail.com>
> ---
> Here is the todo list for reference: https://www.kernel.org/doc/html/latest/gpu/todo.html#transition-away-from-using-deprecated-mipi-dsi-functions
> 
> This is my first patch in Linux Kernel :)
> 
>   drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c b/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c
> index 3c3308fc55df..03c87c02fb57 100644
> --- a/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c
> +++ b/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c
> @@ -44,7 +44,12 @@ static inline struct wuxga_nt_panel *to_wuxga_nt_panel(struct drm_panel *panel)
>   
>   static int wuxga_nt_panel_on(struct wuxga_nt_panel *wuxga_nt)
>   {
> -	return mipi_dsi_turn_on_peripheral(wuxga_nt->dsi);
> +	struct mipi_dsi_multi_context dsi_ctx = {
> +		.dsi = wuxga_nt->dsi
> +	};
> +
> +	mipi_dsi_turn_on_peripheral_multi(&dsi_ctx);
> +	return dsi_ctx.accum_err;
>   }
>   
>   static int wuxga_nt_panel_disable(struct drm_panel *panel)

Why didn't you also update wuxga_nt_panel_disable() ?

Thanks,
Neil

  reply	other threads:[~2026-01-06  8:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-27 16:08 Avinal Kumar
2026-01-06  8:21 ` neil.armstrong [this message]
     [not found]   ` <CAJ9xu4wb1W08ds7f4y+5tzcpAxsNLvKDMAxpjjigsG9ipWREGQ@mail.gmail.com>
2026-01-06  8:56     ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a9f7c54-3669-4f8b-b46b-b7e01712a1b8@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=airlied@gmail.com \
    --cc=avinal.xlvii@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jessica.zhang@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®