From: "Arnd Bergmann" <arnd@arndb.de>
To: "Brigham Campbell" <me@brighamcampbell.com>,
"Arnd Bergmann" <arnd@kernel.org>,
"Linus Walleij" <linusw@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Dave Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Doug Anderson" <dianders@chromium.org>
Cc: "Jessica Zhang" <jesszhan0024@gmail.com>,
"Anusha Srivatsa" <asrivats@redhat.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/panel: novatek-nt35560: avoid on-stack device structure
Date: Wed, 10 Dec 2025 16:00:22 +0100 [thread overview]
Message-ID: <2ac20c84-2544-408f-a29a-8ae88ef3969c@app.fastmail.com> (raw)
In-Reply-To: <DEU9O691LF9V.142HEUAU7DZDR@brighamcampbell.com>
On Wed, Dec 10, 2025, at 05:54, Brigham Campbell wrote:
> On Thu Dec 4, 2025 at 2:45 AM MST, Arnd Bergmann wrote:
>> Change this to a pointer as was liley intended here.
>
> Shoot, you're absolutely right that I didn't mean to create a copy of
> the struct on the stack when I wrote that code. Thanks for the fix! I'll
> try to be more careful with struct usage and the stack in the future.
>
> Can I ask how you got the build process to emit those warnings? I didn't
> see it when I developed my patch.
I'm doing randconfig tests to check a large number of possible configurations.
I also have the CONFIG_FRAME_WARN logic replaced with lower configuration
specific default to catch more regressions in this particular area.
Arnd
prev parent reply other threads:[~2025-12-10 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 9:45 Arnd Bergmann
2025-12-04 17:33 ` Doug Anderson
2025-12-10 4:54 ` Brigham Campbell
2025-12-10 15:00 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ac20c84-2544-408f-a29a-8ae88ef3969c@app.fastmail.com \
--to=arnd@arndb.de \
--cc=airlied@gmail.com \
--cc=arnd@kernel.org \
--cc=asrivats@redhat.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=me@brighamcampbell.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®