* Re: [PATCH] ipv6: Fix nexthop reference count in ip6_route_info_create()
@ 2020-07-25 9:34 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-07-25 9:34 UTC (permalink / raw)
To: Xiyu Yang, Xin Tan, netdev
Cc: linux-kernel, Alexey Kuznetsov, David S. Miller,
Hideaki Yoshifuji, Jakub Kicinski
…
> When ip6_route_info_create() returns, local variable "nh" becomes
> invalid, so the refcount should be decreased to keep refcount balanced.
Can it be helpful to use the term “reference count” in consistent ways?
> Fix this issue
How do you think about to replace this wording by the tag “Fixes”?
> by pulling up the error source routing handling when
> nexthops can not be used with source routing.
Does the movement of an if statement according to the check of the
data structure member “rt->fib6_src.plen” in an if branch really help here?
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-07-25 9:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-25 9:34 [PATCH] ipv6: Fix nexthop reference count in ip6_route_info_create() Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®