From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Peng Fan <peng.fan@linux.dev>, Thomas Gleixner <tglx@kernel.org>,
Radu Rendec <radu@rendec.net>,
Krzysztof Kozlowski <krzk@kernel.org>,
Peter Griffin <peter.griffin@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Ryan Chen <ryan_chen@aspeedtech.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Billy Tsai <billy_tsai@aspeedtech.com>,
Tan Siewert <tan.siewert@9elements.com>,
Eddie James <eajames@linux.ibm.com>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Caleb James DeLisle <cjd@cjdns.fr>, Marc Zyngier <maz@kernel.org>,
Miodrag Dinic <miodrag.dinic@mips.com>,
Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Herve Codina <herve.codina@bootlin.com>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>,
Anup Patel <anup@brainfault.org>, Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Samuel Holland <samuel.holland@sifive.com>,
Qin Jian <qinjian@cqplus1.com>,
Changhuang Liang <changhuang.liang@starfivetech.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Chen-Yu Tsai <wens@kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Michal Simek <michal.simek@amd.com>,
Anirudha Sarangi <anirudha.sarangi@amd.com>,
Tushar Nimkar <tushar.nimkar@amd.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org,
openbmc@lists.ozlabs.org, linux-aspeed@lists.ozlabs.org,
linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
imx@lists.linux.dev, loongarch@lists.linux.dev,
linux-riscv@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-sunxi@lists.linux.dev, git@amd.com,
linux-arm-msm@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH] irqchip: Convert chained handlers to guard_chained_irq()
Date: Mon, 16 Nov 2026 15:12:57 -0800 [thread overview]
Message-ID: <2ad1cc65-0381-478c-959e-9bee1a597110@broadcom.com> (raw)
In-Reply-To: <20261114-irqchip-cleanup-api-v1-1-4a9d598b0bdb@nxp.com>
On 11/14/26 07:06, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Use the scope-based guard_chained_irq() helper in all chained handlers
> under drivers/irqchip/ so that chained_irq_exit() is always invoked when
> the handler returns. Handlers that duplicated the exit call on an error
> path or jumped to a common exit label simply return now and rely on the
> guard.
>
> No functional changes.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> With [1] now merged in irq/drivers, convert the chained IRQ handlers in
> drivers/irqchip/ to use guard_chained_irq(). This removes the explicit
> chained_irq_exit() calls and the gotos that only existed to reach them,
> reducing boilerplate.
>
> I use a script to do the job, and after that, do mannual checking.
>
> No functional changes.
>
> [1] https://lore.kernel.org/all/179417458323.2093942.14330197609841896598.tip-bot2@tip-bot2/#t
> ---
> drivers/irqchip/irq-bcm2836.c | 4 +---
> drivers/irqchip/irq-bcm6345-l1.c | 4 +---
> drivers/irqchip/irq-bcm7038-l1.c | 4 +---
> drivers/irqchip/irq-bcm7120-l2.c | 4 +---
> drivers/irqchip/irq-brcmstb-l2.c | 4 +---
For those drivers above:
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
prev parent reply other threads:[~2026-11-16 23:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 15:06 Peng Fan
2026-11-16 23:12 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ad1cc65-0381-478c-959e-9bee1a597110@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=Frank.Li@nxp.com \
--cc=alex@ghiti.fr \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=andrew@codeconstruct.com.au \
--cc=andrew@lunn.ch \
--cc=anirudha.sarangi@amd.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=benh@kernel.crashing.org \
--cc=billy_tsai@aspeedtech.com \
--cc=changhuang.liang@starfivetech.com \
--cc=chenhuacai@kernel.org \
--cc=cjd@cjdns.fr \
--cc=eajames@linux.ibm.com \
--cc=festevam@gmail.com \
--cc=git@amd.com \
--cc=gregory.clement@bootlin.com \
--cc=herve.codina@bootlin.com \
--cc=imx@lists.linux.dev \
--cc=jernej.skrabec@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=joel@jms.id.au \
--cc=kernel@pengutronix.de \
--cc=kernel@xen0n.name \
--cc=kristo@kernel.org \
--cc=krzk@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=loongarch@lists.linux.dev \
--cc=maz@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@amd.com \
--cc=miodrag.dinic@mips.com \
--cc=nm@ti.com \
--cc=openbmc@lists.ozlabs.org \
--cc=palmer@dabbelt.com \
--cc=peng.fan@linux.dev \
--cc=peng.fan@nxp.com \
--cc=peter.griffin@linaro.org \
--cc=piotr.wojtaszczyk@timesys.com \
--cc=pjw@kernel.org \
--cc=qinjian@cqplus1.com \
--cc=radu@rendec.net \
--cc=rjui@broadcom.com \
--cc=ryan_chen@aspeedtech.com \
--cc=s.hauer@pengutronix.de \
--cc=samuel.holland@sifive.com \
--cc=sbranden@broadcom.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=ssantosh@kernel.org \
--cc=tan.siewert@9elements.com \
--cc=tglx@kernel.org \
--cc=tushar.nimkar@amd.com \
--cc=vz@mleia.com \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®