From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Artur Weber <aweber.kernel@gmail.com>, Lee Jones <lee@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: Stanislav Jakubek <stano.jakubek@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/6] dt-bindings: mfd: brcm,bcm59056: Convert to YAML
Date: Tue, 31 Oct 2023 14:54:24 +0100 [thread overview]
Message-ID: <2ae3d997-7a3e-487b-9d18-0101c3ba8e8e@linaro.org> (raw)
In-Reply-To: <0a4ae01e-fd47-4468-b7c1-527977e53965@gmail.com>
On 31/10/2023 10:36, Artur Weber wrote:
>
>
> On 31.10.2023 06:52, Krzysztof Kozlowski wrote:
>> On 30/10/2023 20:36, Artur Weber wrote:
>>> Convert devicetree bindings for the Broadcom BCM59056 PMU MFD from
>>> TXT to YAML format. This patch does not change any functionality;
>>> the bindings remain the same.
>>> ...
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + interrupts:
>>> + maxItems: 1
>>> +
>>
>> There is no other feature here, so this should go to regulators directory.
>
> There are no other features *yet*, but the driver will eventually be
> expanded to support the other features of the PMIC (charger, fuel gauge,
> rtc, etc.).
The bindings should be complete regardless of driver support, but if
things are missing then it's okay. It can be in MFD.
>
> In that case, should I move the bindings to regulators for now, and move
> them back when the other features are added, or would it be fine to keep
> it in mfd?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-31 13:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 19:36 [PATCH 0/6] mfd: bcm590xx: Add support for BCM59054 Artur Weber
2023-10-30 19:36 ` [PATCH 1/6] dt-bindings: mfd: brcm,bcm59056: Convert to YAML Artur Weber
2023-10-31 5:52 ` Krzysztof Kozlowski
2023-10-31 9:36 ` Artur Weber
2023-10-31 13:54 ` Krzysztof Kozlowski [this message]
2023-10-30 19:36 ` [PATCH 2/6] dt-bindings: mfd: brcm,bcm59056: Add compatible for BCM59054 Artur Weber
2023-10-31 5:54 ` Krzysztof Kozlowski
2023-10-30 19:36 ` [PATCH 3/6] ARM: dts: Drop DTS for BCM59056 PMIC Artur Weber
2023-10-30 19:36 ` [PATCH 4/6] mfd: bcm590xx: Add compatible for BCM59054 Artur Weber
2023-10-31 3:38 ` kernel test robot
2023-11-06 9:46 ` kernel test robot
2023-10-30 19:36 ` [PATCH 5/6] regulator: bcm590xx: Add support " Artur Weber
2023-11-06 15:04 ` kernel test robot
2023-10-30 19:36 ` [PATCH 6/6] regulator: bcm590xx: Add proper handling for PMMODE registers Artur Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ae3d997-7a3e-487b-9d18-0101c3ba8e8e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aweber.kernel@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stano.jakubek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®