From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Artur Weber <aweber.kernel@gmail.com>, Lee Jones <lee@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: Stanislav Jakubek <stano.jakubek@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/6] dt-bindings: mfd: brcm,bcm59056: Add compatible for BCM59054
Date: Tue, 31 Oct 2023 06:54:07 +0100 [thread overview]
Message-ID: <a0742798-982d-4461-9731-aac41fcf8be3@linaro.org> (raw)
In-Reply-To: <20231030-bcm59054-v1-2-3517f980c1e3@gmail.com>
On 30/10/2023 20:36, Artur Weber wrote:
> The BCM59054 MFD is fairly similar to the BCM59056, and will use
> the same driver. Add compatible and specify the allowed regulator
> nodes.
>
> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
> ---
> .../devicetree/bindings/mfd/brcm,bcm59056.yaml | 125 +++++++++++++++------
> 1 file changed, 88 insertions(+), 37 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/brcm,bcm59056.yaml b/Documentation/devicetree/bindings/mfd/brcm,bcm59056.yaml
> index 6d6acc9fd312..5b5044867eca 100644
> --- a/Documentation/devicetree/bindings/mfd/brcm,bcm59056.yaml
> +++ b/Documentation/devicetree/bindings/mfd/brcm,bcm59056.yaml
> @@ -12,6 +12,7 @@ maintainers:
> properties:
> compatible:
> enum:
> + - "brcm,bcm59054"
Where do you see syntax with quotes?
> - "brcm,bcm59056"
>
> reg:
> @@ -24,43 +25,93 @@ properties:
> type: object
> description: Container node for regulators.
>
> - # The valid regulator node names for BCM59056 are:
> - # rfldo, camldo1, camldo2, simldo1, simldo2, sdldo, sdxldo,
> - # mmcldo1, mmcldo2, audldo, micldo, usbldo, vibldo,
> - # csr, iosr1, iosr2, msr, sdsr1, sdsr2, vsr,
> - # gpldo1, gpldo2, gpldo3, gpldo4, gpldo5, gpldo6,
> - # vbus
> - patternProperties:
> - "^(cam|sim|mmc)ldo[1-2]$":
> - type: object
> - $ref: /schemas/regulator/regulator.yaml#
> - unevaluatedProperties: false
> -
> - "^(rf|sd|sdx|aud|mic|usb|vib)ldo$":
> - type: object
> - $ref: /schemas/regulator/regulator.yaml#
> - unevaluatedProperties: false
> -
> - "^(c|m|v)sr$":
> - type: object
> - $ref: /schemas/regulator/regulator.yaml#
> - unevaluatedProperties: false
> -
> - "^(io|sd)sr[1-2]$":
> - type: object
> - $ref: /schemas/regulator/regulator.yaml#
> - unevaluatedProperties: false
> -
> - "^gpldo[1-6]$":
> - type: object
> - $ref: /schemas/regulator/regulator.yaml#
> - unevaluatedProperties: false
> -
> - properties:
> - "vbus":
> - type: object
> - $ref: /schemas/regulator/regulator.yaml#
> - unevaluatedProperties: false
> +allOf:
No. We do not define properties in allOf:if: block. If there are just
few differences, define all at the top level and disallow few (foo-bar:
false). If there are more, just create separate bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-31 5:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 19:36 [PATCH 0/6] mfd: bcm590xx: Add support " Artur Weber
2023-10-30 19:36 ` [PATCH 1/6] dt-bindings: mfd: brcm,bcm59056: Convert to YAML Artur Weber
2023-10-31 5:52 ` Krzysztof Kozlowski
2023-10-31 9:36 ` Artur Weber
2023-10-31 13:54 ` Krzysztof Kozlowski
2023-10-30 19:36 ` [PATCH 2/6] dt-bindings: mfd: brcm,bcm59056: Add compatible for BCM59054 Artur Weber
2023-10-31 5:54 ` Krzysztof Kozlowski [this message]
2023-10-30 19:36 ` [PATCH 3/6] ARM: dts: Drop DTS for BCM59056 PMIC Artur Weber
2023-10-30 19:36 ` [PATCH 4/6] mfd: bcm590xx: Add compatible for BCM59054 Artur Weber
2023-10-31 3:38 ` kernel test robot
2023-11-06 9:46 ` kernel test robot
2023-10-30 19:36 ` [PATCH 5/6] regulator: bcm590xx: Add support " Artur Weber
2023-11-06 15:04 ` kernel test robot
2023-10-30 19:36 ` [PATCH 6/6] regulator: bcm590xx: Add proper handling for PMMODE registers Artur Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0742798-982d-4461-9731-aac41fcf8be3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aweber.kernel@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stano.jakubek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®