From: Chanwoo Choi <cwchoi00@gmail.com>
To: Pan Chuang <panchuang@vivo.com>,
Dmitry Osipenko <digetx@gmail.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
"open list:MEMORY FREQUENCY SCALING DRIVERS FOR NVIDIA TEGRA"
<linux-pm@vger.kernel.org>,
"open list:MEMORY FREQUENCY SCALING DRIVERS FOR NVIDIA TEGRA"
<linux-tegra@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PM / devfreq: tegra30: Remove redundant dev_err()
Date: Mon, 16 Nov 2026 07:56:59 +0900 [thread overview]
Message-ID: <2af4c490-8655-4afd-8c1d-1894f910dcc3@gmail.com> (raw)
In-Reply-To: <20260713131316.322358-1-panchuang@vivo.com>
On 7/13/2026 10:13 PM, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
> drivers/devfreq/tegra30-devfreq.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> index 401aac6a9f07..d149694becd9 100644
> --- a/drivers/devfreq/tegra30-devfreq.c
> +++ b/drivers/devfreq/tegra30-devfreq.c
> @@ -880,10 +880,8 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
> err = devm_request_threaded_irq(&pdev->dev, tegra->irq, NULL,
> actmon_thread_isr, IRQF_ONESHOT,
> "tegra-devfreq", tegra);
> - if (err) {
> - dev_err(&pdev->dev, "Interrupt request failed: %d\n", err);
> + if (err)
> return err;
> - }
>
> err = devm_pm_opp_set_config(&pdev->dev, &config);
> if (err) {
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Principal Engineer, Samsung Electronics
prev parent reply other threads:[~2026-11-15 22:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 13:13 Pan Chuang
2026-11-15 22:56 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2af4c490-8655-4afd-8c1d-1894f910dcc3@gmail.com \
--to=cwchoi00@gmail.com \
--cc=chanwoo@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=panchuang@vivo.com \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®