mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] PM / devfreq: tegra30: Remove redundant dev_err()
@ 2026-07-13 13:13 Pan Chuang
  2026-11-15 22:56 ` Chanwoo Choi
  0 siblings, 1 reply; 2+ messages in thread
From: Pan Chuang @ 2026-07-13 13:13 UTC (permalink / raw)
  To: Dmitry Osipenko, MyungJoo Ham, Kyungmin Park, Chanwoo Choi,
	Thierry Reding, Jonathan Hunter,
	open list:MEMORY FREQUENCY SCALING DRIVERS FOR NVIDIA TEGRA,
	open list:MEMORY FREQUENCY SCALING DRIVERS FOR NVIDIA TEGRA,
	open list
  Cc: Pan Chuang

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/devfreq/tegra30-devfreq.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
index 401aac6a9f07..d149694becd9 100644
--- a/drivers/devfreq/tegra30-devfreq.c
+++ b/drivers/devfreq/tegra30-devfreq.c
@@ -880,10 +880,8 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
 	err = devm_request_threaded_irq(&pdev->dev, tegra->irq, NULL,
 					actmon_thread_isr, IRQF_ONESHOT,
 					"tegra-devfreq", tegra);
-	if (err) {
-		dev_err(&pdev->dev, "Interrupt request failed: %d\n", err);
+	if (err)
 		return err;
-	}
 
 	err = devm_pm_opp_set_config(&pdev->dev, &config);
 	if (err) {
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] PM / devfreq: tegra30: Remove redundant dev_err()
  2026-07-13 13:13 [PATCH] PM / devfreq: tegra30: Remove redundant dev_err() Pan Chuang
@ 2026-11-15 22:56 ` Chanwoo Choi
  0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2026-11-15 22:56 UTC (permalink / raw)
  To: Pan Chuang, Dmitry Osipenko, MyungJoo Ham, Kyungmin Park,
	Chanwoo Choi, Thierry Reding, Jonathan Hunter,
	open list:MEMORY FREQUENCY SCALING DRIVERS FOR NVIDIA TEGRA,
	open list:MEMORY FREQUENCY SCALING DRIVERS FOR NVIDIA TEGRA,
	open list

On 7/13/2026 10:13 PM, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
> 
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
>  drivers/devfreq/tegra30-devfreq.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> index 401aac6a9f07..d149694becd9 100644
> --- a/drivers/devfreq/tegra30-devfreq.c
> +++ b/drivers/devfreq/tegra30-devfreq.c
> @@ -880,10 +880,8 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
>  	err = devm_request_threaded_irq(&pdev->dev, tegra->irq, NULL,
>  					actmon_thread_isr, IRQF_ONESHOT,
>  					"tegra-devfreq", tegra);
> -	if (err) {
> -		dev_err(&pdev->dev, "Interrupt request failed: %d\n", err);
> +	if (err)
>  		return err;
> -	}
>  
>  	err = devm_pm_opp_set_config(&pdev->dev, &config);
>  	if (err) {

Applied it. Thanks.

-- 
Best Regards,
Chanwoo Choi
Principal Engineer, Samsung Electronics

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-15 22:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-13 13:13 [PATCH] PM / devfreq: tegra30: Remove redundant dev_err() Pan Chuang
2026-11-15 22:56 ` Chanwoo Choi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®