[PATCH] btrfs: return a literal instead of a variable

[PATCH] btrfs: return a literal instead of a variable

[Dan Carpenter]

This is just a small clean up, it doesn't change how the code works.
Originally this code had a goto so we needed to set "ret = 0;" but now
it returns directly and so we can simplify it a bit by doing a
"return 0;" and removing the assignment.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 fs/btrfs/dev-replace.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
index 1a82e88ec5c1..53d7d85cb4be 100644
--- a/fs/btrfs/dev-replace.c
+++ b/fs/btrfs/dev-replace.c
@@ -103,7 +103,6 @@ int btrfs_init_dev_replace(struct btrfs_fs_info *fs_info)
 			"found replace target device without a valid replace item");
 			return -EUCLEAN;
 		}
-		ret = 0;
 		dev_replace->replace_state =
 			BTRFS_IOCTL_DEV_REPLACE_STATE_NEVER_STARTED;
 		dev_replace->cont_reading_from_srcdev_mode =
@@ -120,7 +119,7 @@ int btrfs_init_dev_replace(struct btrfs_fs_info *fs_info)
 		dev_replace->tgtdev = NULL;
 		dev_replace->is_valid = 0;
 		dev_replace->item_needs_writeback = 0;
-		return ret;
+		return 0;
 	}
 	slot = path->slots[0];
 	eb = path->nodes[0];
-- 
2.47.2

Re: [PATCH] btrfs: return a literal instead of a variable

[Anand Jain]

looks good.
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Thx

Re: [PATCH] btrfs: return a literal instead of a variable

[David Sterba]

On Wed, Mar 05, 2025 at 06:01:57PM +0300, Dan Carpenter wrote:
> This is just a small clean up, it doesn't change how the code works.
> Originally this code had a goto so we needed to set "ret = 0;" but now
> it returns directly and so we can simplify it a bit by doing a
> "return 0;" and removing the assignment.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Added to for-next, thanks.