From: Krzysztof Kozlowski <krzk@kernel.org>
To: Thierry Reding <thierry.reding@kernel.org>
Cc: Svyatoslav Ryhel <clamor95@gmail.com>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Mikko Perttunen <mperttunen@nvidia.com>,
Sumit Gupta <sumitg@nvidia.com>,
Dmitry Osipenko <digetx@gmail.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH v1 3/5] dt-bindings: memory: Add Tegra114 memory client IDs
Date: Sat, 28 Mar 2026 13:11:34 +0100 [thread overview]
Message-ID: <2b3b4c35-06b9-460b-9488-5da6f43fc069@kernel.org> (raw)
In-Reply-To: <22870432-521b-40c0-8f4a-93d2c605baa7@kernel.org>
On 28/03/2026 12:40, Krzysztof Kozlowski wrote:
> On 28/03/2026 00:53, Thierry Reding wrote:
>> On Tue, Feb 17, 2026 at 08:22:24AM +0100, Krzysztof Kozlowski wrote:
>>> On 26/01/2026 20:07, Svyatoslav Ryhel wrote:
>>>> Each memory client has unique hardware ID, add these IDs.
>>>>
>>>> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
>>>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
>>>> Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
>>>> ---
>>>> include/dt-bindings/memory/tegra114-mc.h | 67 ++++++++++++++++++++++++
>>>
>>> This is never a separate commit. Squash with the binding.
>>
>> You have previously requested that bindings and driver changes be
>> applied together. If this header file is applied to your memory tree it
>> means I cannot apply the corresponding DT changes until a release later
>> because the defines are part of the header included in the DT bindings
>> patch.
>
> I cannot apply the driver either without it, because it uses it, no?
> Otherwise what is it doing in bindings if the driver is not using it?
>
>>
>> Seems a bit suboptimal. Do you have any good ideas on how to solve that
>
> We listed five already in maintainer soc profile. Are they not good?
>
>> particular issue? The only one that comes to mind is for you to pick up
>> the DT changes as well, though that obviously runs a greater risk of
>> causing merge conflicts down the road.
One more thing:
There is no DTS here and nothing explains (commit msgs, changelogs or
cover letter) that there is any dependency and this was supposed to go
other tree. So the squash-or-not-squash is absolutely irrelevant to your
question/problem how DTS should deal with it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-28 12:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 19:07 [PATCH v1 0/5] Tegra114: implement EMC support Svyatoslav Ryhel
2026-01-26 19:07 ` [PATCH v1 1/5] dt-bindings: memory: Document Tegra114 Memory Controller Svyatoslav Ryhel
2026-01-26 19:07 ` [PATCH v1 2/5] memory: tegra: implement EMEM regs and ICC ops for Tegra114 Svyatoslav Ryhel
2026-01-26 19:07 ` [PATCH v1 3/5] dt-bindings: memory: Add Tegra114 memory client IDs Svyatoslav Ryhel
2026-02-17 7:22 ` Krzysztof Kozlowski
2026-02-17 8:02 ` Svyatoslav Ryhel
2026-02-17 8:15 ` Krzysztof Kozlowski
2026-02-17 8:24 ` Svyatoslav Ryhel
2026-03-27 23:53 ` Thierry Reding
2026-03-28 11:40 ` Krzysztof Kozlowski
2026-03-28 12:11 ` Krzysztof Kozlowski [this message]
2026-01-26 19:07 ` [PATCH v1 4/5] dt-bindings: memory: Document Tegra114 External Memory Controller Svyatoslav Ryhel
2026-01-26 19:07 ` [PATCH v1 5/5] memory: tegra: Add Tegra114 EMC driver Svyatoslav Ryhel
2026-02-17 7:21 ` Krzysztof Kozlowski
2026-02-17 7:51 ` Svyatoslav Ryhel
2026-02-17 8:18 ` Krzysztof Kozlowski
2026-02-17 8:29 ` Svyatoslav Ryhel
2026-02-17 8:33 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b3b4c35-06b9-460b-9488-5da6f43fc069@kernel.org \
--to=krzk@kernel.org \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=robh@kernel.org \
--cc=sumitg@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox