Re: [PATCH v1 5/5] memory: tegra: Add Tegra114 EMC driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On 17/02/2026 09:29, Svyatoslav Ryhel wrote:
>>>>>
>>>>>  obj-$(CONFIG_TEGRA20_EMC)  += tegra20-emc.o
>>>>>  obj-$(CONFIG_TEGRA30_EMC)  += tegra30-emc.o
>>>>> +obj-$(CONFIG_TEGRA114_EMC) += tegra114-emc.o
>>>>>  obj-$(CONFIG_TEGRA124_EMC) += tegra124-emc.o
>>>>>  obj-$(CONFIG_TEGRA210_EMC_TABLE) += tegra210-emc-table.o
>>>>>  obj-$(CONFIG_TEGRA210_EMC) += tegra210-emc.o
>>>>> diff --git a/drivers/memory/tegra/tegra114-emc.c b/drivers/memory/tegra/tegra114-emc.c
>>>>> new file mode 100644
>>>>> index 000000000000..789b8e959a68
>>>>> --- /dev/null
>>>>> +++ b/drivers/memory/tegra/tegra114-emc.c
>>>>> @@ -0,0 +1,1463 @@
>>>>> +// SPDX-License-Identifier: GPL-2.0-only
>>>>> +/*
>>>>> + * Tegra114 External Memory Controller driver
>>>>> + *
>>>>> + * Based on downstream driver from NVIDIA and tegra124-emc.c
>>>>> + * Copyright (C) 2011-2014 NVIDIA Corporation
>>>>> + *
>>>>> + * Copyright (C) 2024 Svyatoslav Ryhel <clamor95@gmail.com>
>>>>> + */
>>>>> +
>>>>> +#include <linux/clk-provider.h>
>>>>
>>>> Where is it used?
>>>>
>>>>> +#include <linux/clk.h>
>>>>> +#include <linux/clkdev.h>
>>>>
>>>> Where is it used?
>>>>
>>>>> +#include <linux/clk/tegra.h>
>>>>
>>>> Where is it used?
>>>>
>>>
>>> All 4 by tegra124_clk_set_emc_callbacks
>>
>> What? That's not how C works.
>>
>> There is no definition of tegra124_clk_set_emc_callbacks here in this
>> patch, so the headers are not used. Point me to any symbols from these
>> headers being used in this patch.
>>
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/clk/tegra.h?h=v6.19#n199
> 

This is different header, I asked for using in this patch (or rather
this C unit). Plus that header does not even use things I asked above -
no clkdev, no interconnect, no clk provider.

Best regards,
Krzysztof