* [PATCH] pinctrl: qcom: sm8250-lpass-lpi: Fix i2s2_data_groups definition
@ 2026-01-28 11:22 Luca Weiss
2026-01-28 11:27 ` Konrad Dybcio
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Luca Weiss @ 2026-01-28 11:22 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Srinivas Kandagatla, Krzysztof Kozlowski
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
linux-gpio, linux-kernel, Luca Weiss
The i2s2_data function is available on both gpio12 and gpio13. Fix the
groups definition.
Fixes: 6e261d1090d6 ("pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver")
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c
index 64494a86490e..c27452eece3e 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c
@@ -73,7 +73,7 @@ static const char * const i2s1_ws_groups[] = { "gpio7" };
static const char * const i2s1_data_groups[] = { "gpio8", "gpio9" };
static const char * const wsa_swr_clk_groups[] = { "gpio10" };
static const char * const wsa_swr_data_groups[] = { "gpio11" };
-static const char * const i2s2_data_groups[] = { "gpio12", "gpio12" };
+static const char * const i2s2_data_groups[] = { "gpio12", "gpio13" };
static const struct lpi_pingroup sm8250_groups[] = {
LPI_PINGROUP(0, 0, swr_tx_clk, qua_mi2s_sclk, _, _),
---
base-commit: 4f938c7d3b25d87b356af4106c2682caf8c835a2
change-id: 20260128-sm8250-lpass-lpi-fix-3bc112c2994a
Best regards,
--
Luca Weiss <luca.weiss@fairphone.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: qcom: sm8250-lpass-lpi: Fix i2s2_data_groups definition
2026-01-28 11:22 [PATCH] pinctrl: qcom: sm8250-lpass-lpi: Fix i2s2_data_groups definition Luca Weiss
@ 2026-01-28 11:27 ` Konrad Dybcio
2026-01-29 0:46 ` Dmitry Baryshkov
2026-02-03 0:22 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2026-01-28 11:27 UTC (permalink / raw)
To: Luca Weiss, Bjorn Andersson, Linus Walleij, Srinivas Kandagatla,
Krzysztof Kozlowski
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
linux-gpio, linux-kernel
On 1/28/26 12:22 PM, Luca Weiss wrote:
> The i2s2_data function is available on both gpio12 and gpio13. Fix the
> groups definition.
>
> Fixes: 6e261d1090d6 ("pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
docs agree
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: qcom: sm8250-lpass-lpi: Fix i2s2_data_groups definition
2026-01-28 11:22 [PATCH] pinctrl: qcom: sm8250-lpass-lpi: Fix i2s2_data_groups definition Luca Weiss
2026-01-28 11:27 ` Konrad Dybcio
@ 2026-01-29 0:46 ` Dmitry Baryshkov
2026-02-03 0:22 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2026-01-29 0:46 UTC (permalink / raw)
To: Luca Weiss
Cc: Bjorn Andersson, Linus Walleij, Srinivas Kandagatla,
Krzysztof Kozlowski, ~postmarketos/upstreaming, phone-devel,
linux-arm-msm, linux-gpio, linux-kernel
On Wed, Jan 28, 2026 at 12:22:28PM +0100, Luca Weiss wrote:
> The i2s2_data function is available on both gpio12 and gpio13. Fix the
> groups definition.
>
> Fixes: 6e261d1090d6 ("pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: qcom: sm8250-lpass-lpi: Fix i2s2_data_groups definition
2026-01-28 11:22 [PATCH] pinctrl: qcom: sm8250-lpass-lpi: Fix i2s2_data_groups definition Luca Weiss
2026-01-28 11:27 ` Konrad Dybcio
2026-01-29 0:46 ` Dmitry Baryshkov
@ 2026-02-03 0:22 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2026-02-03 0:22 UTC (permalink / raw)
To: Luca Weiss
Cc: Bjorn Andersson, Srinivas Kandagatla, Krzysztof Kozlowski,
~postmarketos/upstreaming, phone-devel, linux-arm-msm,
linux-gpio, linux-kernel
On Wed, Jan 28, 2026 at 12:22 PM Luca Weiss <luca.weiss@fairphone.com> wrote:
> The i2s2_data function is available on both gpio12 and gpio13. Fix the
> groups definition.
>
> Fixes: 6e261d1090d6 ("pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver")
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-03 0:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-28 11:22 [PATCH] pinctrl: qcom: sm8250-lpass-lpi: Fix i2s2_data_groups definition Luca Weiss
2026-01-28 11:27 ` Konrad Dybcio
2026-01-29 0:46 ` Dmitry Baryshkov
2026-02-03 0:22 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®