From: "Cédric Le Goater" <clg@redhat.com>
To: Oleksandr Natalenko <oleksandr@natalenko.name>,
linux-kernel@vger.kernel.org
Cc: Alex Williamson <alex.williamson@redhat.com>,
Eric Auger <eric.auger@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Abhishek Sahu <abhsahu@nvidia.com>,
Kevin Tian <kevin.tian@intel.com>,
Cornelia Huck <cohuck@redhat.com>, Bo Liu <liubo03@inspur.com>,
"K V P, Satyanarayana" <satyanarayana.k.v.p@intel.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH] vfio/pci: demote hiding ecap messages to debug level
Date: Thu, 4 May 2023 17:05:42 +0200 [thread overview]
Message-ID: <2b6567ca-3e0e-02ea-0f5e-f7121c8d4b2c@redhat.com> (raw)
In-Reply-To: <20230504131654.24922-1-oleksandr@natalenko.name>
On 5/4/23 15:16, Oleksandr Natalenko wrote:
> Seeing a burst of messages like this:
>
> vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0
> vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x25@0x200
> vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x26@0x210
> vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x27@0x250
> vfio-pci 0000:98:00.1: vfio_ecap_init: hiding ecap 0x25@0x200
> vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0
> vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x25@0x200
> vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x26@0x210
> vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x27@0x250
> vfio-pci 0000:b1:00.1: vfio_ecap_init: hiding ecap 0x25@0x200
>
> is of little to no value for an ordinary user.
>
> Hence, use pci_dbg() instead of pci_info().
>
> Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Acked-by: Cédric Le Goater <clg@redhat.com>
Thanks,
C.
> ---
> drivers/vfio/pci/vfio_pci_config.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c
> index 948cdd464f4e..dd8dda14e701 100644
> --- a/drivers/vfio/pci/vfio_pci_config.c
> +++ b/drivers/vfio/pci/vfio_pci_config.c
> @@ -1643,7 +1643,7 @@ static int vfio_ecap_init(struct vfio_pci_core_device *vdev)
> }
>
> if (!len) {
> - pci_info(pdev, "%s: hiding ecap %#x@%#x\n",
> + pci_dbg(pdev, "%s: hiding ecap %#x@%#x\n",
> __func__, ecap, epos);
>
> /* If not the first in the chain, we can skip over it */
next prev parent reply other threads:[~2023-05-04 15:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 13:16 Oleksandr Natalenko
2023-05-04 15:05 ` Cédric Le Goater [this message]
2023-05-04 23:01 ` Alex Williamson
2023-05-05 10:01 ` Oleksandr Natalenko
2023-05-20 7:41 ` Yanghang Luy
2023-05-23 22:43 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b6567ca-3e0e-02ea-0f5e-f7121c8d4b2c@redhat.com \
--to=clg@redhat.com \
--cc=abhsahu@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liubo03@inspur.com \
--cc=oleksandr@natalenko.name \
--cc=satyanarayana.k.v.p@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®