* Re: [PATCH] ARM: zx： Remove duplicate error message
@ 2020-04-02 14:00 Markus Elfring
[not found] ` <2020040222473842104710@cmss.chinamobile.com>
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-04-02 14:00 UTC (permalink / raw)
To: tangbin, Jun Nie, Russell King, Shawn Guo, linux-arm-kernel; +Cc: linux-kernel
> remove duplicate dev_err message, because of
> devm_ioremap_resource, which has already contains.
I suggest to reconsider the wording for the final commit message.
Will the previous update suggestion “ARM: zx: Use devm_platform_ioremap_resource()
in zx296702_pd_probe()” get also a bit more software development attention?
https://lore.kernel.org/linux-arm-kernel/30b6c588-6c4b-c8ff-6414-a3fc53867bfe@web.de/
https://lore.kernel.org/patchwork/patch/1128530/
https://lkml.org/lkml/2019/9/18/50
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: ARM: zx: Remove duplicate error message
[not found] ` <2020040222473842104710@cmss.chinamobile.com>
@ 2020-04-02 16:04 ` Markus Elfring
0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2020-04-02 16:04 UTC (permalink / raw)
To: tangbin, Jun Nie, Russell King, Shawn Guo, linux-arm-kernel; +Cc: linux-kernel
> Thank you for your replay。
I hope that you interpret my reply as another constructive patch review.
> I'm a newer here
The possibilities for further contributions are interesting, aren't they?
> and I don't receive any suggestion for this patch,
You got a positive tag by Jun Nie.
> so maybe the committer think it is useless。
The proposed change is generally helpful.
* Additional dependencies might be relevant for the software evolution.
* Please improve also the spelling for the commit message.
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-02 16:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-02 14:00 [PATCH] ARM: zx： Remove duplicate error message Markus Elfring
[not found] ` <2020040222473842104710@cmss.chinamobile.com>
2020-04-02 16:04 ` ARM: zx: " Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®