(no subject)

[Joao Bonifacio]

The following is a small change made to the file removing the zero values from the initializations.

[PATCH 1/2] net: intel: Remove unnecessary static variable initialization

[Joao Bonifacio]

Static variables in C are implicitly initialized to zero,
so there is no need to explicitly set
and  to 0. This change removes the redundant initialization

Signed-off-by: Joao Bonifacio <joaoboni017@gmail.com>
---
 drivers/net/ethernet/intel/e100.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c
index 3a5bbda235cb..f5d32663a89a 100644
--- a/drivers/net/ethernet/intel/e100.c
+++ b/drivers/net/ethernet/intel/e100.c
@@ -167,8 +167,8 @@ MODULE_FIRMWARE(FIRMWARE_D101S);
 MODULE_FIRMWARE(FIRMWARE_D102E);
 
 static int debug = 3;
-static int eeprom_bad_csum_allow = 0;
-static int use_io = 0;
+static int eeprom_bad_csum_allow;
+static int use_io;
 module_param(debug, int, 0);
 module_param(eeprom_bad_csum_allow, int, 0444);
 module_param(use_io, int, 0444);
-- 
2.48.1

Re: [PATCH 1/2] net: intel: Remove unnecessary static variable initialization

[Przemek Kitszel]

On 3/11/25 23:15, Joao Bonifacio wrote:
> Static variables in C are implicitly initialized to zero,
> so there is no need to explicitly set
> and  to 0. This change removes the redundant initialization

Thank you for reaching out, and sorry, but this change by itself is too
trivial, see:
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#clean-up-patches

some feedback anyway:
the Subject line of this patch is too generic
whitespace formatting of the next paragraph of commit message is off

for networking we tag patches as "net" (fixes) and "next-net" (the rest)
and in particular for series that are mostly Intel eth we tag instead as
"iwl-net" and "iwl-next"

> 
> Signed-off-by: Joao Bonifacio <joaoboni017@gmail.com>
> ---
>   drivers/net/ethernet/intel/e100.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c
> index 3a5bbda235cb..f5d32663a89a 100644
> --- a/drivers/net/ethernet/intel/e100.c
> +++ b/drivers/net/ethernet/intel/e100.c
> @@ -167,8 +167,8 @@ MODULE_FIRMWARE(FIRMWARE_D101S);
>   MODULE_FIRMWARE(FIRMWARE_D102E);
>   
>   static int debug = 3;
> -static int eeprom_bad_csum_allow = 0;
> -static int use_io = 0;
> +static int eeprom_bad_csum_allow;
> +static int use_io;
>   module_param(debug, int, 0);
>   module_param(eeprom_bad_csum_allow, int, 0444);
>   module_param(use_io, int, 0444);