* Reg: redundancy in inet socket
@ 2007-05-25 15:10 Tej Parkash
0 siblings, 0 replies; only message in thread
From: Tej Parkash @ 2007-05-25 15:10 UTC (permalink / raw)
To: linux-kernel
list_for_each_rcu(p, &inetsw[sock->type]) {
answer = list_entry(p, struct inet_protosw, list);
/* Check the non-wild match. */
if (protocol == answer->protocol) {
if (protocol != IPPROTO_IP)
break;
} else {
/* Check for the two wild cases. */
if (IPPROTO_IP == protocol) {
protocol = answer->protocol;
break;
}
if (IPPROTO_IP == answer->protocol)
break;
}
i think there is a problem in this code because if (protocol ==
answer->protocol) will be more like an assignment rather then
comparison
pl cc to me.
TEJ
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-05-25 15:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-25 15:10 Reg: redundancy in inet socket Tej Parkash
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®