* [PATCH v2] firmware: xlnx-zynqmp: fix compilation warning
@ 2020-11-24 8:18 Wendy Liang
2020-11-24 14:28 ` Michal Simek
0 siblings, 1 reply; 2+ messages in thread
From: Wendy Liang @ 2020-11-24 8:18 UTC (permalink / raw)
To: michal.simek, rajan.vaja, gregkh, tejas.patel, manish.narani
Cc: linux-arm-kernel, linux-kernel, Wendy Liang
Fix compilation warning when ZYNQMP_FIRMWARE is not defined.
include/linux/firmware/xlnx-zynqmp.h: In function
'zynqmp_pm_get_eemi_ops':
include/linux/firmware/xlnx-zynqmp.h:363:9: error: implicit
declaration of function 'ERR_PTR'
[-Werror=implicit-function-declaration]
363 | return ERR_PTR(-ENODEV);
include/linux/firmware/xlnx-zynqmp.h:363:18: note: each undeclared
identifier is reported only once for each function it appears in
include/linux/firmware/xlnx-zynqmp.h: In function
'zynqmp_pm_get_api_version':
include/linux/firmware/xlnx-zynqmp.h:367:10: error: 'ENODEV'
undeclared (first use in this function)
367 | return -ENODEV;
| ^~~~~~
Signed-off-by: Wendy Liang <wendy.liang@xilinx.com>
---
v2:
* Always include linux/err.h
---
include/linux/firmware/xlnx-zynqmp.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h
index 5968df8..f84244e 100644
--- a/include/linux/firmware/xlnx-zynqmp.h
+++ b/include/linux/firmware/xlnx-zynqmp.h
@@ -13,6 +13,8 @@
#ifndef __FIRMWARE_ZYNQMP_H__
#define __FIRMWARE_ZYNQMP_H__
+#include <linux/err.h>
+
#define ZYNQMP_PM_VERSION_MAJOR 1
#define ZYNQMP_PM_VERSION_MINOR 0
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] firmware: xlnx-zynqmp: fix compilation warning
2020-11-24 8:18 [PATCH v2] firmware: xlnx-zynqmp: fix compilation warning Wendy Liang
@ 2020-11-24 14:28 ` Michal Simek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2020-11-24 14:28 UTC (permalink / raw)
To: Wendy Liang, michal.simek, rajan.vaja, gregkh, tejas.patel,
manish.narani
Cc: linux-arm-kernel, linux-kernel
On 24. 11. 20 9:18, Wendy Liang wrote:
> Fix compilation warning when ZYNQMP_FIRMWARE is not defined.
>
> include/linux/firmware/xlnx-zynqmp.h: In function
> 'zynqmp_pm_get_eemi_ops':
> include/linux/firmware/xlnx-zynqmp.h:363:9: error: implicit
> declaration of function 'ERR_PTR'
> [-Werror=implicit-function-declaration]
> 363 | return ERR_PTR(-ENODEV);
>
> include/linux/firmware/xlnx-zynqmp.h:363:18: note: each undeclared
> identifier is reported only once for each function it appears in
> include/linux/firmware/xlnx-zynqmp.h: In function
> 'zynqmp_pm_get_api_version':
> include/linux/firmware/xlnx-zynqmp.h:367:10: error: 'ENODEV'
> undeclared (first use in this function)
> 367 | return -ENODEV;
> | ^~~~~~
>
> Signed-off-by: Wendy Liang <wendy.liang@xilinx.com>
> ---
> v2:
> * Always include linux/err.h
> ---
> include/linux/firmware/xlnx-zynqmp.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h
> index 5968df8..f84244e 100644
> --- a/include/linux/firmware/xlnx-zynqmp.h
> +++ b/include/linux/firmware/xlnx-zynqmp.h
> @@ -13,6 +13,8 @@
> #ifndef __FIRMWARE_ZYNQMP_H__
> #define __FIRMWARE_ZYNQMP_H__
>
> +#include <linux/err.h>
> +
> #define ZYNQMP_PM_VERSION_MAJOR 1
> #define ZYNQMP_PM_VERSION_MINOR 0
>
>
Applied for next.
M
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-24 14:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-24 8:18 [PATCH v2] firmware: xlnx-zynqmp: fix compilation warning Wendy Liang
2020-11-24 14:28 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®