mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ray Lee" <madrabbit@gmail.com>
To: "Jesper Juhl" <jesper.juhl@gmail.com>
Cc: "Andrew Morton" <akpm@osdl.org>,
	tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@elte.hu,
	trini@kernel.crashing.org
Subject: Re: [patch 1/2] Validate itimer timeval from userspace
Date: Sat, 18 Mar 2006 14:02:43 -0800	[thread overview]
Message-ID: <2c0942db0603181402o4115999jb990ac05cca7fb9e@mail.gmail.com> (raw)
In-Reply-To: <9a8748490603181245v47b9f0a5v1ef252f91c30a7d2@mail.gmail.com>

On 3/18/06, Jesper Juhl <jesper.juhl@gmail.com> wrote:
> If the change only affects buggy apps (as Thomas says), then it seems
> completely obvious to me that the change should be made.

But the app isn't buggy, it's just not coded to some arbitrary spec.
Further, an arbitrary spec that *the kernel didn't implement*. The app
author could very well have been competent and tested that behavior in
a ten line program (I do that sort of code *all the time* to test
corner cases that aren't clear in man pages). Once tested, they found
out -1 is an effectively infinite timeout, went "Hey, cool, that makes
sense", and went on with their day.

You're now arguing that we should break apps -- possibly well tested
apps -- because they didn't implement a spec that the kernel itself
wasn't implementing.

That's just nuts.

> 3. Correct applications are unaffected.

You're assuming that the apps that we'd break are incorrect. That's a
big assumption. Try imagining instead that it's a well-tested app that
passed QA with flying colors on a previous version of the kernel. They
exist. Honest.

Ray

  reply	other threads:[~2006-03-18 22:02 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-18 15:18 [patch 0/2] sys_setitimer and sys_alarm hotfixes Thomas Gleixner
2006-03-18 15:18 ` [patch 1/2] Validate itimer timeval from userspace Thomas Gleixner
2006-03-18 19:10   ` Ingo Molnar
2006-03-18 19:57     ` Thomas Gleixner
2006-03-18 20:07   ` Andrew Morton
2006-03-18 20:16     ` Thomas Gleixner
2006-03-18 20:31       ` Andrew Morton
2006-03-18 20:38         ` Thomas Gleixner
2006-03-18 21:09           ` Andrew Morton
2006-03-18 21:26             ` Jesper Juhl
2006-03-18 21:33               ` Andrew Morton
2006-03-18 21:50                 ` Jesper Juhl
2006-03-18 22:05             ` Thomas Gleixner
2006-03-18 22:25               ` Andrew Morton
2006-03-18 23:12                 ` tglx
2006-03-18 20:45         ` Jesper Juhl
2006-03-18 22:02           ` Ray Lee [this message]
2006-03-18 23:14           ` Eric Piel
2006-03-19  8:55             ` Kyle Moffett
2006-03-18 20:23     ` Jesper Juhl
2006-03-18 20:30       ` Thomas Gleixner
2006-03-18 21:04         ` Andrew Morton
2006-03-21 15:31           ` Pavel Machek
2006-03-18 15:18 ` [patch 2/2] alarm unsigned signed conversion fixup Thomas Gleixner
2006-03-18 20:02   ` Thomas Gleixner
2006-03-18 20:12   ` Andrew Morton
2006-03-18 20:27     ` Thomas Gleixner
2006-03-18 21:06       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c0942db0603181402o4115999jb990ac05cca7fb9e@mail.gmail.com \
    --to=madrabbit@gmail.com \
    --cc=akpm@osdl.org \
    --cc=jesper.juhl@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=ray-gmail@madrabbit.org \
    --cc=tglx@linutronix.de \
    --cc=trini@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®