From: "Ray Lee" <ray-lk@madrabbit.org>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: "Al Viro" <viro@zeniv.linux.org.uk>,
"David Newall" <davidn@davidnewall.com>,
"Krzysztof Halasa" <khc@pm.waw.pl>,
"Adrian Bunk" <bunk@kernel.org>,
"Roland Dreier" <rdreier@cisco.com>,
"Glenn Streiff" <gstreiff@neteffect.com>,
"Faisal Latif" <flatif@neteffect.com>,
linux-kernel@vger.kernel.org, general@lists.openfabrics.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"Greg Kroah-Hartman" <greg@kroah.com>
Subject: Re: Merging of completely unreviewed drivers
Date: Thu, 21 Feb 2008 22:37:00 -0800 [thread overview]
Message-ID: <2c0942db0802212237t41da54b4h2aa2b052b7633f53@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.1.00.0802211858140.19896@woody.linux-foundation.org>
On Thu, Feb 21, 2008 at 7:13 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> So I'd be happier with warnings about deep indentation (but how do you
> count it? Will people then try to fake things out by using 4-space indents
> and then "deep" indentations will look like just a couple of tabs?)
I suspect that 90% of the cases that people really care about would
get caught successfully just by counting brace depth.
ie, by looking at { { {} {} {{{}{}}} } } I bet you can tell me which
section should have been pulled out into a separate routine.
next prev parent reply other threads:[~2008-02-22 6:37 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 22:59 [2.6 patch] infiniband/hw/nes/nes_verbs.c: fix off-by-one Adrian Bunk
2008-02-20 4:23 ` [ofa-general] " Roland Dreier
2008-02-20 5:57 ` Adrian Bunk
2008-02-20 23:21 ` Roland Dreier
2008-02-20 23:27 ` Glenn Streiff
2008-02-21 12:39 ` Glenn Streiff
2008-02-21 15:49 ` Adrian Bunk
2008-02-21 20:28 ` Roland Dreier
2008-02-21 21:01 ` Merging of completely unreviewed drivers Adrian Bunk
2008-02-21 21:09 ` Roland Dreier
2008-02-21 21:14 ` Linus Torvalds
2008-02-21 22:33 ` Alexey Dobriyan
2008-02-21 22:43 ` Greg KH
2008-02-21 22:57 ` Jeff Garzik
2008-02-21 22:58 ` Alexey Dobriyan
2008-02-21 23:31 ` Jan Engelhardt
2008-02-21 23:38 ` Krzysztof Halasa
2008-02-21 23:31 ` Alan Cox
2008-02-22 0:29 ` Adrian Bunk
2008-02-21 23:41 ` Jeff Garzik
2008-02-22 0:05 ` Krzysztof Halasa
2008-02-22 0:44 ` Jeff Garzik
2008-02-22 2:02 ` Krzysztof Halasa
2008-02-22 10:04 ` Alan Cox
2008-02-22 18:45 ` Pavel Machek
2008-02-22 22:44 ` Krzysztof Halasa
2008-02-23 9:43 ` Pavel Machek
2008-02-23 12:38 ` David Newall
2008-02-23 15:25 ` Pavel Machek
2008-02-24 3:18 ` David Newall
2008-02-23 17:33 ` Linus Torvalds
2008-02-24 3:26 ` David Newall
2008-02-24 4:47 ` Linus Torvalds
2008-02-23 13:58 ` Krzysztof Halasa
2008-02-22 1:46 ` David Newall
2008-02-22 2:06 ` Al Viro
2008-02-22 2:23 ` Krzysztof Halasa
2008-02-22 3:13 ` Al Viro
2008-02-22 22:28 ` Krzysztof Halasa
2008-02-24 7:47 ` Jörn Engel
2008-02-24 14:47 ` Krzysztof Halasa
2008-02-22 3:13 ` Linus Torvalds
2008-02-22 6:29 ` [ofa-general] " Junio C Hamano
2008-02-22 9:02 ` Adrian Bunk
2008-02-22 6:37 ` Ray Lee [this message]
2008-02-23 15:31 ` Jan Engelhardt
2008-02-24 3:22 ` David Newall
2008-02-22 22:37 ` Krzysztof Halasa
2008-02-22 12:29 ` [ofa-general] " Bart Van Assche
2008-02-22 14:25 ` David Newall
2008-02-22 15:17 ` Peter Zijlstra
2008-02-22 16:48 ` John W. Linville
2008-02-22 22:59 ` Krzysztof Halasa
2008-02-22 23:14 ` Al Viro
2008-02-22 15:48 ` John W. Linville
2008-02-22 18:54 ` Ingo Molnar
2008-02-22 19:11 ` [ofa-general] " Bart Van Assche
2008-02-22 19:20 ` Jeff Garzik
2008-02-22 19:44 ` Greg KH
2008-02-21 21:30 ` Greg KH
2008-02-22 1:06 ` Adrian Bunk
2008-02-21 22:08 ` Arjan van de Ven
2008-02-21 22:33 ` Jeff Garzik
2008-02-21 23:40 ` Adrian Bunk
2008-02-22 18:40 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c0942db0802212237t41da54b4h2aa2b052b7633f53@mail.gmail.com \
--to=ray-lk@madrabbit.org \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=davidn@davidnewall.com \
--cc=flatif@neteffect.com \
--cc=general@lists.openfabrics.org \
--cc=greg@kroah.com \
--cc=gstreiff@neteffect.com \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome