From: Shuah Khan <skhan@linuxfoundation.org>
To: shuah@kernel.org, Liam.Howlett@oracle.com,
anjali.k.kulkarni@oracle.com, kuba@kernel.org
Cc: Shuah Khan <skhan@linuxfoundation.org>,
davem@davemloft.net, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH next 3/3] selftests:connector: Add root check and fix arg error paths to skip
Date: Fri, 28 Jul 2023 11:29:28 -0600 [thread overview]
Message-ID: <2c0ac97f9c8e6bd46b60854c136099c0dd4a09f6.1690564372.git.skhan@linuxfoundation.org> (raw)
In-Reply-To: <cover.1690564372.git.skhan@linuxfoundation.org>
proc_filter test requires root privileges. Add root privilege check
and skip the test. Also fix argument parsing paths to skip in their
error legs.
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
---
tools/testing/selftests/connector/proc_filter.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/connector/proc_filter.c b/tools/testing/selftests/connector/proc_filter.c
index 4fe8c6763fd8..7b2081b98e5c 100644
--- a/tools/testing/selftests/connector/proc_filter.c
+++ b/tools/testing/selftests/connector/proc_filter.c
@@ -248,7 +248,7 @@ int main(int argc, char *argv[])
if (argc > 2) {
printf("Expected 0(assume no-filter) or 1 argument(-f)\n");
- exit(1);
+ exit(KSFT_SKIP);
}
if (argc == 2) {
@@ -256,10 +256,15 @@ int main(int argc, char *argv[])
filter = 1;
} else {
printf("Valid option : -f (for filter feature)\n");
- exit(1);
+ exit(KSFT_SKIP);
}
}
+ if (geteuid()) {
+ printf("Connector test requires root privileges.\n");
+ exit(KSFT_SKIP);
+ }
+
if (filter) {
input.event_type = PROC_EVENT_NONZERO_EXIT;
input.mcast_op = PROC_CN_MCAST_LISTEN;
--
2.39.2
next prev parent reply other threads:[~2023-07-28 17:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 17:29 [PATCH next 0/3] Connector/proc_filter test fixes Shuah Khan
2023-07-28 17:29 ` [PATCH next 1/3] selftests:connector: Fix Makefile to include KHDR_INCLUDES Shuah Khan
2023-07-31 21:55 ` Anjali Kulkarni
2023-07-28 17:29 ` Shuah Khan [this message]
2023-07-28 18:10 ` [PATCH next 3/3] selftests:connector: Add root check and fix arg error paths to skip Anjali Kulkarni
2023-07-28 19:06 ` Shuah Khan
2023-07-28 19:44 ` Shuah Khan
2023-07-28 21:21 ` Anjali Kulkarni
2023-07-28 21:41 ` Shuah Khan
2023-07-28 21:59 ` Anjali Kulkarni
2023-07-28 22:25 ` Shuah Khan
2023-07-28 22:40 ` Anjali Kulkarni
2023-07-28 23:00 ` Shuah Khan
2023-07-29 0:19 ` Anjali Kulkarni
2023-07-29 0:32 ` Shuah Khan
2023-07-29 0:58 ` Anjali Kulkarni
2023-07-29 1:02 ` Anjali Kulkarni
2023-07-31 21:50 ` [PATCH next 0/3] Connector/proc_filter test fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c0ac97f9c8e6bd46b60854c136099c0dd4a09f6.1690564372.git.skhan@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=anjali.k.kulkarni@oracle.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®