From: Shuah Khan <skhan@linuxfoundation.org>
To: shuah@kernel.org, Liam.Howlett@oracle.com,
anjali.k.kulkarni@oracle.com, naresh.kamboju@linaro.org,
kuba@kernel.org
Cc: Shuah Khan <skhan@linuxfoundation.org>,
davem@davemloft.net, lkft-triage@lists.linaro.org,
netdev@vger.kernel.org, llvm@lists.linux.dev,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH next 1/3] selftests:connector: Fix Makefile to include KHDR_INCLUDES
Date: Fri, 28 Jul 2023 11:29:26 -0600 [thread overview]
Message-ID: <d0055c8cdf18516db8ba9edec99cfc5c08f32a7c.1690564372.git.skhan@linuxfoundation.org> (raw)
In-Reply-To: <cover.1690564372.git.skhan@linuxfoundation.org>
The test compile fails with following errors. Fix the Makefile
CFLAGS to include KHDR_INCLUDES to pull in uapi defines.
gcc -Wall proc_filter.c -o ../tools/testing/selftests/connector/proc_filter
proc_filter.c: In function ‘send_message’:
proc_filter.c:22:33: error: invalid application of ‘sizeof’ to incomplete type ‘struct proc_input’
22 | sizeof(struct proc_input))
| ^~~~~~
proc_filter.c:42:19: note: in expansion of macro ‘NL_MESSAGE_SIZE’
42 | char buff[NL_MESSAGE_SIZE];
| ^~~~~~~~~~~~~~~
proc_filter.c:22:33: error: invalid application of ‘sizeof’ to incomplete type ‘struct proc_input’
22 | sizeof(struct proc_input))
| ^~~~~~
proc_filter.c:48:34: note: in expansion of macro ‘NL_MESSAGE_SIZE’
48 | hdr->nlmsg_len = NL_MESSAGE_SIZE;
| ^~~~~~~~~~~~~~~
`
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Link: https://lore.kernel.org/all/CA+G9fYt=6ysz636XcQ=-KJp7vJcMZ=NjbQBrn77v7vnTcfP2cA@mail.gmail.com/
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
---
tools/testing/selftests/connector/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/connector/Makefile b/tools/testing/selftests/connector/Makefile
index 21c9f3a973a0..92188b9bac5c 100644
--- a/tools/testing/selftests/connector/Makefile
+++ b/tools/testing/selftests/connector/Makefile
@@ -1,5 +1,5 @@
# SPDX-License-Identifier: GPL-2.0
-CFLAGS += -Wall
+CFLAGS += -Wall $(KHDR_INCLUDES)
TEST_GEN_PROGS = proc_filter
--
2.39.2
next prev parent reply other threads:[~2023-07-28 17:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 17:29 [PATCH next 0/3] Connector/proc_filter test fixes Shuah Khan
2023-07-28 17:29 ` Shuah Khan [this message]
2023-07-31 21:55 ` [PATCH next 1/3] selftests:connector: Fix Makefile to include KHDR_INCLUDES Anjali Kulkarni
2023-07-28 17:29 ` [PATCH next 3/3] selftests:connector: Add root check and fix arg error paths to skip Shuah Khan
2023-07-28 18:10 ` Anjali Kulkarni
2023-07-28 19:06 ` Shuah Khan
2023-07-28 19:44 ` Shuah Khan
2023-07-28 21:21 ` Anjali Kulkarni
2023-07-28 21:41 ` Shuah Khan
2023-07-28 21:59 ` Anjali Kulkarni
2023-07-28 22:25 ` Shuah Khan
2023-07-28 22:40 ` Anjali Kulkarni
2023-07-28 23:00 ` Shuah Khan
2023-07-29 0:19 ` Anjali Kulkarni
2023-07-29 0:32 ` Shuah Khan
2023-07-29 0:58 ` Anjali Kulkarni
2023-07-29 1:02 ` Anjali Kulkarni
2023-07-31 21:50 ` [PATCH next 0/3] Connector/proc_filter test fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0055c8cdf18516db8ba9edec99cfc5c08f32a7c.1690564372.git.skhan@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=anjali.k.kulkarni@oracle.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=llvm@lists.linux.dev \
--cc=naresh.kamboju@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®