From: Wesley Cheng <quic_wcheng@quicinc.com>
To: Takashi Iwai <tiwai@suse.de>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: <agross@kernel.org>, <andersson@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<catalin.marinas@arm.com>, <will@kernel.org>,
<mathias.nyman@intel.com>, <gregkh@linuxfoundation.org>,
<lgirdwood@gmail.com>, <broonie@kernel.org>, <perex@perex.cz>,
<tiwai@suse.com>, <srinivas.kandagatla@linaro.org>,
<bgoswami@quicinc.com>, <Thinh.Nguyen@synopsys.com>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-usb@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<quic_jackp@quicinc.com>, <oneukum@suse.com>,
<albertccwang@google.com>, <o-takashi@sakamocchi.jp>
Subject: Re: [PATCH v4 31/32] sound: usb: card: Allow for rediscovery of connected USB SND devices
Date: Mon, 28 Aug 2023 14:25:14 -0700 [thread overview]
Message-ID: <2c0e76ab-1e3a-70d6-24dc-32b2e66c2a3a@quicinc.com> (raw)
In-Reply-To: <87wmyotk74.wl-tiwai@suse.de>
Hi Takashi,
On 7/25/2023 2:27 AM, Takashi Iwai wrote:
> On Tue, 25 Jul 2023 11:15:11 +0200,
> Pierre-Louis Bossart wrote:
>>
>>
>>
>> On 7/25/23 04:34, Wesley Cheng wrote:
>>> In case of notifying SND platform drivers of connection events, some of
>>> these use cases, such as offloading, require an ASoC USB backend device to
>>> be initialized before the events can be handled. If the USB backend device
>>> has not yet been probed, this leads to missing initial USB audio device
>>> connection events.
>>>
>>> Expose an API that traverses the usb_chip array for connected devices, and
>>> to call the respective connection callback registered to the SND platform
>>> driver.
>>>
>>> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
>>> ---
>>> sound/usb/card.c | 19 +++++++++++++++++++
>>> sound/usb/card.h | 2 ++
>>> 2 files changed, 21 insertions(+)
>>>
>>> diff --git a/sound/usb/card.c b/sound/usb/card.c
>>> index 365f6d978608..27a89aaa0bf3 100644
>>> --- a/sound/usb/card.c
>>> +++ b/sound/usb/card.c
>>> @@ -170,6 +170,25 @@ struct snd_usb_stream *snd_usb_find_suppported_substream(int card_idx,
>>> }
>>> EXPORT_SYMBOL_GPL(snd_usb_find_suppported_substream);
>>>
>>> +/*
>>> + * in case the platform driver was not ready at the time of USB SND
>>> + * device connect, expose an API to discover all connected USB devices
>>> + * so it can populate any dependent resources/structures.
>>> + */
>>> +void snd_usb_rediscover_devices(void)
>>> +{
>>> + int i;
>>> +
>>> + mutex_lock(®ister_mutex);
>>> + for (i = 0; i < SNDRV_CARDS; i++) {
>>> + if (usb_chip[i])
>>> + if (platform_ops && platform_ops->connect_cb)
>>> + platform_ops->connect_cb(usb_chip[i]);
>>
>> what happens if the USB device is removed while the platform device adds
>> a port?
>
> That should be protected by the register_mutex. But there can be
> other races (see below :)
>
>> This sounds super-racy to me. It's the same set of problems we're having
>> between audio and display/DRM, I would be surprised if this function
>> dealt with all corner cases of insertion/removal, bind/unbind.
>
> Yes, we need to be more careful about binding.
>
> For example, in the current patch set, I see no way to prevent
> unloading snd-usb-audio-qmi module, and it allows user to cut off the
> stuff during operation, which may break things while the kernel is
> running the code of the unloaded module. You need to have a proper
> module refcount management for avoiding such a scenario. Most of
> drivers don't need it because ALSA core part already takes care of
> it. But in this case, it requires a manual adjustment.
>
Sorry for the delayed response...this was routed to another folder, and
missed it.
I see, that is a valid situation, so I think the best way to address it
is to do something like the following:
static void __exit qc_usb_audio_offload_exit(void)
{
...
snd_usb_unregister_platform_ops();
for (idx = 0; idx < SNDRV_CARDS; idx++)
qc_usb_audio_offload_disconnect(uadev[idx].chip);
We'll first unregister the platform ops, so that we get no further
connect/disconnect CBs, and then we'll forcefully ensure that all
devices are removed/cleaned. Part of the USB offload disconnect
sequence will also forcefully stop the offload path on the external DSP
by issuing a disconnect indication QMI message.
Then we can safely clean up the rest of the resources. We do have
refcounting in place for several of the other structures, but I think in
the module exit case, we need to ensure the offload path is stopped fully.
Thanks
Wesley Cheng
next prev parent reply other threads:[~2023-08-28 21:27 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 2:33 [PATCH v4 00/32] Introduce QC USB SND audio offloading support Wesley Cheng
2023-07-25 2:33 ` [PATCH v4 01/32] xhci: add support to allocate several interrupters Wesley Cheng
2023-07-25 5:35 ` Greg KH
2023-07-25 10:00 ` Oliver Neukum
2023-07-25 2:33 ` [PATCH v4 02/32] xhci: add helper to stop endpoint and wait for completion Wesley Cheng
2023-07-25 2:33 ` [PATCH v4 03/32] xhci: sideband: add initial api to register a sideband entity Wesley Cheng
2023-07-25 2:57 ` Randy Dunlap
2023-07-25 2:33 ` [PATCH v4 04/32] usb: host: xhci-mem: Cleanup pending secondary event ring events Wesley Cheng
2023-08-03 10:33 ` Mathias Nyman
2023-07-25 2:33 ` [PATCH v4 05/32] usb: host: xhci-mem: Allow for interrupter clients to choose specific index Wesley Cheng
2023-07-25 2:33 ` [PATCH v4 06/32] ASoC: Add SOC USB APIs for adding an USB backend Wesley Cheng
2023-07-25 8:10 ` Pierre-Louis Bossart
2023-07-25 23:17 ` Wesley Cheng
2023-07-25 2:33 ` [PATCH v4 07/32] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: Add USB_RX port Wesley Cheng
2023-07-25 2:33 ` [PATCH v4 08/32] ASoC: qcom: qdsp6: Introduce USB AFE port to q6dsp Wesley Cheng
2023-07-25 8:27 ` Pierre-Louis Bossart
2023-08-07 23:39 ` Wesley Cheng
2023-07-25 2:33 ` [PATCH v4 09/32] ASoC: qdsp6: q6afe: Increase APR timeout Wesley Cheng
2023-07-25 2:33 ` [PATCH v4 10/32] ASoC: qcom: Add USB backend ASoC driver for Q6 Wesley Cheng
2023-07-25 8:45 ` Pierre-Louis Bossart
2023-08-08 0:50 ` Wesley Cheng
2023-07-25 2:33 ` [PATCH v4 11/32] sound: usb: card: Introduce USB SND platform op callbacks Wesley Cheng
2023-07-25 6:55 ` Takashi Iwai
2023-07-25 2:33 ` [PATCH v4 12/32] sound: usb: Export USB SND APIs for modules Wesley Cheng
2023-07-25 5:04 ` Trilok Soni
2023-07-25 5:33 ` Greg KH
2023-07-25 6:52 ` Takashi Iwai
2023-07-25 2:33 ` [PATCH v4 13/32] dt-bindings: usb: dwc3: Add snps,num-hc-interrupters definition Wesley Cheng
2023-07-26 17:19 ` Rob Herring
2023-08-29 6:31 ` Krzysztof Kozlowski
2023-07-25 2:33 ` [PATCH v4 14/32] usb: dwc3: Add DT parameter to specify maximum number of interrupters Wesley Cheng
2023-07-25 2:33 ` [PATCH v4 15/32] usb: host: xhci-plat: Set XHCI max interrupters if property is present Wesley Cheng
2023-07-25 2:34 ` [PATCH v4 16/32] sound: usb: pcm: Export fixed rate check USB SND API Wesley Cheng
2023-07-25 2:34 ` [PATCH v4 17/32] sound: usb: qcom: Add USB QMI definitions Wesley Cheng
2023-07-25 2:34 ` [PATCH v4 18/32] sound: usb: Introduce QC USB SND offloading support Wesley Cheng
2023-07-25 2:57 ` Randy Dunlap
2023-07-25 7:26 ` Takashi Iwai
2023-07-25 22:59 ` Wesley Cheng
2023-07-26 12:31 ` Takashi Iwai
2023-07-25 2:34 ` [PATCH v4 19/32] sound: usb: card: Check for support for requested audio format Wesley Cheng
2023-07-25 6:57 ` Takashi Iwai
2023-07-25 2:34 ` [PATCH v4 20/32] sound: soc: soc-usb: Add PCM format check API for USB backend Wesley Cheng
2023-07-25 2:34 ` [PATCH v4 21/32] sound: soc: qcom: qusb6: Ensure PCM format is supported by USB audio device Wesley Cheng
2023-07-25 2:34 ` [PATCH v4 22/32] sound: usb: Prevent starting of audio stream if in use Wesley Cheng
2023-07-25 2:34 ` [PATCH v4 23/32] ASoC: dt-bindings: Add Q6USB backend bindings Wesley Cheng
2023-07-26 8:00 ` Krzysztof Kozlowski
2023-07-25 2:34 ` [PATCH v4 24/32] ASoC: dt-bindings: Update example for enabling USB offload on SM8250 Wesley Cheng
2023-07-25 4:26 ` Rob Herring
2023-07-25 2:34 ` [PATCH v4 25/32] ASoC: qcom: qdsp6: q6afe: Split USB AFE dev_token param into separate API Wesley Cheng
2023-07-25 2:34 ` [PATCH v4 26/32] sound: Pass USB SND card and PCM information to SOC USB Wesley Cheng
2023-07-25 8:59 ` Pierre-Louis Bossart
2023-08-15 1:48 ` Wesley Cheng
2023-07-25 2:34 ` [PATCH v4 27/32] sound: soc: qdsp6: Add SND kcontrol to select offload device Wesley Cheng
2023-07-25 9:16 ` Pierre-Louis Bossart
2023-07-26 23:06 ` Wesley Cheng
2023-07-25 2:34 ` [PATCH v4 28/32] sound: soc: qdsp6: Add SND kcontrol for fetching offload status Wesley Cheng
2023-07-25 2:34 ` [PATCH v4 29/32] sound: soc: qcom: q6usb: Add headphone jack for offload connection status Wesley Cheng
2023-07-25 9:10 ` Pierre-Louis Bossart
2023-08-16 1:11 ` Wesley Cheng
2023-07-25 2:34 ` [PATCH v4 30/32] sound: usb: qc_audio_offload: Use card and PCM index from QMI request Wesley Cheng
2023-07-25 2:34 ` [PATCH v4 31/32] sound: usb: card: Allow for rediscovery of connected USB SND devices Wesley Cheng
2023-07-25 9:15 ` Pierre-Louis Bossart
2023-07-25 9:27 ` Takashi Iwai
2023-08-28 21:25 ` Wesley Cheng [this message]
2023-08-29 14:06 ` Takashi Iwai
2023-08-16 1:38 ` Wesley Cheng
2023-08-16 15:35 ` Pierre-Louis Bossart
2023-07-25 2:34 ` [PATCH v4 32/32] sound: soc: soc-usb: Rediscover USB SND devices on USB port add Wesley Cheng
2023-07-25 2:38 ` [PATCH v4 00/32] Introduce QC USB SND audio offloading support Wesley Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c0e76ab-1e3a-70d6-24dc-32b2e66c2a3a@quicinc.com \
--to=quic_wcheng@quicinc.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=agross@kernel.org \
--cc=albertccwang@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=o-takashi@sakamocchi.jp \
--cc=oneukum@suse.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=quic_jackp@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®