* [PATCH] fs: ocfs2: namei: Check return value of ocfs2_add_entry()
@ 2023-08-03 14:54 Artem Chernyshev
2023-08-04 1:23 ` Joseph Qi
0 siblings, 1 reply; 2+ messages in thread
From: Artem Chernyshev @ 2023-08-03 14:54 UTC (permalink / raw)
To: Joel Becker, Mark Fasheh
Cc: Artem Chernyshev, Joseph Qi, Kurt Hackel, ocfs2-devel,
linux-kernel, lvc-project
Process result of ocfs2_add_entry() in case we have an error
value.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: ccd979bdbce9 ("[PATCH] OCFS2: The Second Oracle Cluster Filesystem")
Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
---
fs/ocfs2/namei.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
index 17c52225b87d..03bccfd183f3 100644
--- a/fs/ocfs2/namei.c
+++ b/fs/ocfs2/namei.c
@@ -1535,6 +1535,10 @@ static int ocfs2_rename(struct mnt_idmap *idmap,
status = ocfs2_add_entry(handle, new_dentry, old_inode,
OCFS2_I(old_inode)->ip_blkno,
new_dir_bh, &target_insert);
+ if (status < 0) {
+ mlog_errno(status);
+ goto bail;
+ }
}
old_inode->i_ctime = current_time(old_inode);
--
2.37.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fs: ocfs2: namei: Check return value of ocfs2_add_entry()
2023-08-03 14:54 [PATCH] fs: ocfs2: namei: Check return value of ocfs2_add_entry() Artem Chernyshev
@ 2023-08-04 1:23 ` Joseph Qi
0 siblings, 0 replies; 2+ messages in thread
From: Joseph Qi @ 2023-08-04 1:23 UTC (permalink / raw)
To: Artem Chernyshev, Joel Becker, Mark Fasheh, akpm
Cc: Kurt Hackel, ocfs2-devel, linux-kernel, lvc-project
On 8/3/23 10:54 PM, Artem Chernyshev wrote:
> Process result of ocfs2_add_entry() in case we have an error
> value.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: ccd979bdbce9 ("[PATCH] OCFS2: The Second Oracle Cluster Filesystem")
> Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/ocfs2/namei.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
> index 17c52225b87d..03bccfd183f3 100644
> --- a/fs/ocfs2/namei.c
> +++ b/fs/ocfs2/namei.c
> @@ -1535,6 +1535,10 @@ static int ocfs2_rename(struct mnt_idmap *idmap,
> status = ocfs2_add_entry(handle, new_dentry, old_inode,
> OCFS2_I(old_inode)->ip_blkno,
> new_dir_bh, &target_insert);
> + if (status < 0) {
> + mlog_errno(status);
> + goto bail;
> + }
> }
>
> old_inode->i_ctime = current_time(old_inode);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-04 1:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-03 14:54 [PATCH] fs: ocfs2: namei: Check return value of ocfs2_add_entry() Artem Chernyshev
2023-08-04 1:23 ` Joseph Qi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®