From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: vt6655: Use loop in vt6655_mac_write_bssid_addr
Date: Fri, 08 Jul 2022 21:07:43 -0700 [thread overview]
Message-ID: <2c1717b23896bc95a9ba9de79c9dbf112aa35460.camel@perches.com> (raw)
In-Reply-To: <YsgjOPUDDtD48tMO@kroah.com>
On Fri, 2022-07-08 at 14:29 +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 06, 2022 at 09:19:01PM +0200, Philipp Hortmann wrote:
> > Use loop in vt6655_mac_write_bssid_addr to avoid multiple
> > similar statements.
[]
> > diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
[]
> > @@ -192,12 +192,8 @@ device_set_options(struct vnt_private *priv)
> > static void vt6655_mac_write_bssid_addr(void __iomem *iobase, const u8 *mac_addr)
[]
> > + for (int i = 0; i < 6; i++)
>
> Taking advantage of the new compiler level I see, nice :)
Not sure this is altogether a great idea as it may
make backporting a bit difficult, but it's already
in the kernel in a few places.
next prev parent reply other threads:[~2022-07-09 4:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 19:18 [PATCH 0/2] staging: vt6655: Reduce similar statements when working with mac addr Philipp Hortmann
2022-07-06 19:19 ` [PATCH 1/2] staging: vt6655: Use loop in vt6655_mac_write_bssid_addr Philipp Hortmann
2022-07-08 12:29 ` Greg Kroah-Hartman
2022-07-09 4:07 ` Joe Perches [this message]
2022-07-09 7:02 ` Greg Kroah-Hartman
2022-07-06 19:19 ` [PATCH 2/2] staging: vt6655: Use loop in vt6655_mac_read_ether_addr Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c1717b23896bc95a9ba9de79c9dbf112aa35460.camel@perches.com \
--to=joe@perches.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®