From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joe Perches <joe@perches.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] staging: vt6655: Use loop in vt6655_mac_read_ether_addr
Date: Wed, 6 Jul 2022 21:19:06 +0200 [thread overview]
Message-ID: <f233c8a007d75a8adcc99a07c582b75bdc1985db.1657134099.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1657134099.git.philipp.g.hortmann@gmail.com>
Use loop in vt6655_mac_read_ether_addr to avoid multiple
similar statements.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
Code for testing:
for (int i = 0; i < 6; i++){
mac_addr[i] = ioread8(iobase + MAC_REG_PAR0 + i);
printk("i = %i\n", i);
}
Log:
[ 3608.011168] i = 0
[ 3608.011170] i = 1
[ 3608.011172] i = 2
[ 3608.011174] i = 3
[ 3608.011176] i = 4
[ 3608.011178] i = 5
---
drivers/staging/vt6655/device_main.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 099f0b95417a..19840dddb4bf 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -200,12 +200,8 @@ static void vt6655_mac_write_bssid_addr(void __iomem *iobase, const u8 *mac_addr
static void vt6655_mac_read_ether_addr(void __iomem *iobase, u8 *mac_addr)
{
iowrite8(1, iobase + MAC_REG_PAGE1SEL);
- mac_addr[0] = ioread8(iobase + MAC_REG_PAR0);
- mac_addr[1] = ioread8(iobase + MAC_REG_PAR0 + 1);
- mac_addr[2] = ioread8(iobase + MAC_REG_PAR0 + 2);
- mac_addr[3] = ioread8(iobase + MAC_REG_PAR0 + 3);
- mac_addr[4] = ioread8(iobase + MAC_REG_PAR0 + 4);
- mac_addr[5] = ioread8(iobase + MAC_REG_PAR0 + 5);
+ for (int i = 0; i < 6; i++)
+ mac_addr[i] = ioread8(iobase + MAC_REG_PAR0 + i);
iowrite8(0, iobase + MAC_REG_PAGE1SEL);
}
--
2.37.0
prev parent reply other threads:[~2022-07-06 19:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 19:18 [PATCH 0/2] staging: vt6655: Reduce similar statements when working with mac addr Philipp Hortmann
2022-07-06 19:19 ` [PATCH 1/2] staging: vt6655: Use loop in vt6655_mac_write_bssid_addr Philipp Hortmann
2022-07-08 12:29 ` Greg Kroah-Hartman
2022-07-09 4:07 ` Joe Perches
2022-07-09 7:02 ` Greg Kroah-Hartman
2022-07-06 19:19 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f233c8a007d75a8adcc99a07c582b75bdc1985db.1657134099.git.philipp.g.hortmann@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®