From: Dan Murphy <dmurphy@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: <mark.rutland@arm.com>, <rpurdie@rpsys.net>,
<jacek.anaszewski@gmail.com>, <pavel@ucw.cz>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-leds@vger.kernel.org>
Subject: Re: [PATCH] dt: bindings: as3645a: Fix the example node
Date: Wed, 6 Dec 2017 16:32:36 -0600 [thread overview]
Message-ID: <2c2b1fc0-6156-2897-b597-6911fee64556@ti.com> (raw)
In-Reply-To: <20171206215204.7qyjjd2oue7n7l37@rob-hp-laptop>
Rob
On 12/06/2017 03:52 PM, Rob Herring wrote:
> On Tue, Dec 05, 2017 at 07:36:37AM -0600, Dan Murphy wrote:
>> Fix the address-cells and size-cells example node
>> to reflect to the correct representation.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>> Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>> index fdc40e354a64..8a49ccfec29b 100644
>> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>> @@ -59,8 +59,8 @@ Example
>> =======
>>
>> as3645a@30 {
>> - #address-cells: 1
>> - #size-cells: 0
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> reg = <0x30>;
>> compatible = "ams,as3645a";
>
> Convention is also we put compatible first.
>
OK I will move that too for v2.
Can that be in the same patch or do you want a separate patch?
Dan
>> flash@0 {
>> --
>> 2.15.0.124.g7668cbc60
>>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2017-12-06 22:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 13:36 Dan Murphy
2017-12-05 20:03 ` Dan Murphy
2017-12-06 21:52 ` Rob Herring
2017-12-06 22:32 ` Dan Murphy [this message]
2017-12-07 15:42 ` Rob Herring
2017-12-27 21:19 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c2b1fc0-6156-2897-b597-6911fee64556@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®