From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Albert Jakieła" <jakiela@google.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
matthias.bgg@gmail.com, wenst@chromium.org, rafal@milecki.pl,
hsinyi@chromium.org, nfraprado@collabora.com,
sean.wang@mediatek.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 2/2] arm64: dts: mediate: Introduce MT8186 Chinchou/Chinchou360 Chromebooks
Date: Mon, 30 Sep 2024 11:23:23 +0200 [thread overview]
Message-ID: <2c5614f7-0ada-453a-bd81-2f0054a919a0@collabora.com> (raw)
In-Reply-To: <20240927122940.4190949-2-jakiela@google.com>
Il 27/09/24 14:29, Albert Jakieła ha scritto:
> The MT8186 Chinchou/Chinchou360, also known as the Asus Chromebook
> CZ12/CZ11 Flip, is a clamshell or convertible device with touchscreen,
> stylus and extra buttons.
>
You have a typo in your commit title `mediate` -> `mediatek`
> Signed-off-by: Albert Jakieła <jakiela@google.com>
> ---
> Changes in v2:
> - PATCH 2/2: Remove sku2147483647, remove duplicate nodes, add model
> and remove uneccecery nodes from sound card.
> - Link to v1: https://lore.kernel.org/all/20240925080353.2362879-2-jakiela@google.com/
>
> ---
> arch/arm64/boot/dts/mediatek/Makefile | 3 +
> .../mediatek/mt8186-corsola-chinchou-sku0.dts | 18 +
> .../mediatek/mt8186-corsola-chinchou-sku1.dts | 34 ++
> .../mt8186-corsola-chinchou-sku16.dts | 28 ++
> .../dts/mediatek/mt8186-corsola-chinchou.dtsi | 432 ++++++++++++++++++
> 5 files changed, 515 insertions(+)
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dts
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi
>
..snip..
> diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi
> new file mode 100644
> index 000000000000..96cc3c267c20
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi
> @@ -0,0 +1,432 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright 2023 Google LLC
> + */
> +
> +/dts-v1/;
> +#include "mt8186-corsola.dtsi"
> +
> +/ {
..snip..
> +
> +&sound {
> + status = "okay";
> +
> + compatible = "mediatek,mt8186-mt6366-rt5650-sound";
Why did you keep the compatible string override?
> + model = "mt8186_rt5650";
> +
Regards,
Angelo
next prev parent reply other threads:[~2024-09-30 9:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 12:29 [PATCH v2 1/2] dt-bindings: arm: mediatek: Add " Albert Jakieła
2024-09-27 12:29 ` [PATCH v2 2/2] arm64: dts: mediate: Introduce " Albert Jakieła
2024-09-30 9:23 ` AngeloGioacchino Del Regno [this message]
[not found] ` <CAODvyLQ0pUUvBtfk7Pj05vwTkjEnCkfBY4-EG0okQB972tLC-g@mail.gmail.com>
2024-10-01 11:36 ` AngeloGioacchino Del Regno
2024-10-02 9:32 ` Albert Jakieła
2024-09-27 14:21 ` [PATCH v2 1/2] dt-bindings: arm: mediatek: Add " Rob Herring (Arm)
2024-09-27 14:34 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c5614f7-0ada-453a-bd81-2f0054a919a0@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hsinyi@chromium.org \
--cc=jakiela@google.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®