From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Albert Jakieła" <jakiela@google.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
wenst@chromium.org, rafal@milecki.pl, hsinyi@chromium.org,
nfraprado@collabora.com, sean.wang@mediatek.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: mediatek: Add MT8186 Chinchou/Chinchou360 Chromebooks
Date: Fri, 27 Sep 2024 16:34:57 +0200 [thread overview]
Message-ID: <9ea704e6-df1b-4dea-843b-008a3a7c3a67@kernel.org> (raw)
In-Reply-To: <20240927122940.4190949-1-jakiela@google.com>
On 27/09/2024 14:29, Albert Jakieła wrote:
> Add entries for MT8186 based Chinchou/Chinchou360 Chromebooks.
> These two are clamshell or convertible with touchscreen, stylus
> and extra buttons.
>
> Signed-off-by: Albert Jakieła <jakiela@google.com>
> ---
>
> Changes since v1:
> - PATCH 1/2: Delete sku2147483647
> - Link to v1: https://lore.kernel.org/all/20240925080353.2362879-1-jakiela@google.com/
>
> ---
> .../devicetree/bindings/arm/mediatek.yaml | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 1d4bb50fcd8d..47efd96e5659 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -239,6 +239,28 @@ properties:
> - enum:
> - mediatek,mt8183-pumpkin
> - const: mediatek,mt8183
> + - description: Google Chinchou360 (Asus Chromebook CZ11 Flip CZ1104F)
> + items:
> + - const: google,chinchou-sku16
> + - const: google,chinchou-sku18
> + - const: google,chinchou-sku19
> + - const: google,chinchou-sku21
> + - const: mediatek,mt8186
> + - description: Google Chinchou (Asus Chromebook CZ12 Flip CZ1204C)
> + items:
> + - const: google,chinchou-sku0
> + - const: google,chinchou-sku1
> + - const: google,chinchou-sku2
> + - const: google,chinchou-sku3
> + - const: google,chinchou-sku4
> + - const: google,chinchou-sku5
> + - const: google,chinchou-sku6
> + - const: google,chinchou-sku7
> + - const: google,chinchou-sku17
> + - const: google,chinchou-sku22
> + - const: google,chinchou-sku23
> + - const: google,chinchou
> + - const: mediatek,mt8186
These don't match your DTS. Which also means you did not test your DTS. :(
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-27 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 12:29 Albert Jakieła
2024-09-27 12:29 ` [PATCH v2 2/2] arm64: dts: mediate: Introduce " Albert Jakieła
2024-09-30 9:23 ` AngeloGioacchino Del Regno
[not found] ` <CAODvyLQ0pUUvBtfk7Pj05vwTkjEnCkfBY4-EG0okQB972tLC-g@mail.gmail.com>
2024-10-01 11:36 ` AngeloGioacchino Del Regno
2024-10-02 9:32 ` Albert Jakieła
2024-09-27 14:21 ` [PATCH v2 1/2] dt-bindings: arm: mediatek: Add " Rob Herring (Arm)
2024-09-27 14:34 ` Krzysztof Kozlowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-09-27 12:13 Albert Jakieła
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ea704e6-df1b-4dea-843b-008a3a7c3a67@kernel.org \
--to=krzk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hsinyi@chromium.org \
--cc=jakiela@google.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®