* [PATCH] drm/etnaviv: drop driver owner assignment
@ 2024-03-30 20:52 Krzysztof Kozlowski
2024-04-01 10:26 ` Christian Gmeiner
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-03-30 20:52 UTC (permalink / raw)
To: Lucas Stach, Russell King, Christian Gmeiner, David Airlie,
Daniel Vetter, etnaviv, dri-devel, linux-kernel
Cc: Krzysztof Kozlowski
Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
index 734412aae94d..87b31cfee41d 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
@@ -1995,7 +1995,6 @@ static const struct dev_pm_ops etnaviv_gpu_pm_ops = {
struct platform_driver etnaviv_gpu_driver = {
.driver = {
.name = "etnaviv-gpu",
- .owner = THIS_MODULE,
.pm = pm_ptr(&etnaviv_gpu_pm_ops),
.of_match_table = etnaviv_gpu_match,
},
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/etnaviv: drop driver owner assignment
2024-03-30 20:52 [PATCH] drm/etnaviv: drop driver owner assignment Krzysztof Kozlowski
@ 2024-04-01 10:26 ` Christian Gmeiner
2024-04-24 6:41 ` Krzysztof Kozlowski
2024-05-16 17:13 ` Lucas Stach
0 siblings, 2 replies; 4+ messages in thread
From: Christian Gmeiner @ 2024-04-01 10:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lucas Stach, Russell King, David Airlie, Daniel Vetter, etnaviv,
dri-devel, linux-kernel
>
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to. Whatever is set here will be anyway overwritten by
> main driver calling platform_driver_register().
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
> ---
> drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> index 734412aae94d..87b31cfee41d 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> @@ -1995,7 +1995,6 @@ static const struct dev_pm_ops etnaviv_gpu_pm_ops = {
> struct platform_driver etnaviv_gpu_driver = {
> .driver = {
> .name = "etnaviv-gpu",
> - .owner = THIS_MODULE,
> .pm = pm_ptr(&etnaviv_gpu_pm_ops),
> .of_match_table = etnaviv_gpu_match,
> },
> --
> 2.34.1
>
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/etnaviv: drop driver owner assignment
2024-04-01 10:26 ` Christian Gmeiner
@ 2024-04-24 6:41 ` Krzysztof Kozlowski
2024-05-16 17:13 ` Lucas Stach
1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-24 6:41 UTC (permalink / raw)
To: Christian Gmeiner
Cc: Lucas Stach, Russell King, David Airlie, Daniel Vetter, etnaviv,
dri-devel, linux-kernel
On 01/04/2024 12:26, Christian Gmeiner wrote:
>>
>> Core in platform_driver_register() already sets the .owner, so driver
>> does not need to. Whatever is set here will be anyway overwritten by
>> main driver calling platform_driver_register().
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Thanks.
It has been almost a month. Any further comments on this patchset from
maintainers? Can anyone pick it up?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/etnaviv: drop driver owner assignment
2024-04-01 10:26 ` Christian Gmeiner
2024-04-24 6:41 ` Krzysztof Kozlowski
@ 2024-05-16 17:13 ` Lucas Stach
1 sibling, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2024-05-16 17:13 UTC (permalink / raw)
To: Christian Gmeiner, Krzysztof Kozlowski
Cc: Russell King, David Airlie, Daniel Vetter, etnaviv, dri-devel,
linux-kernel
Am Montag, dem 01.04.2024 um 12:26 +0200 schrieb Christian Gmeiner:
> >
> > Core in platform_driver_register() already sets the .owner, so driver
> > does not need to. Whatever is set here will be anyway overwritten by
> > main driver calling platform_driver_register().
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Applied to the etnaviv/next branch.
Regards,
Lucas
>
> > ---
> > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> > index 734412aae94d..87b31cfee41d 100644
> > --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> > @@ -1995,7 +1995,6 @@ static const struct dev_pm_ops etnaviv_gpu_pm_ops = {
> > struct platform_driver etnaviv_gpu_driver = {
> > .driver = {
> > .name = "etnaviv-gpu",
> > - .owner = THIS_MODULE,
> > .pm = pm_ptr(&etnaviv_gpu_pm_ops),
> > .of_match_table = etnaviv_gpu_match,
> > },
> > --
> > 2.34.1
> >
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-16 17:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-30 20:52 [PATCH] drm/etnaviv: drop driver owner assignment Krzysztof Kozlowski
2024-04-01 10:26 ` Christian Gmeiner
2024-04-24 6:41 ` Krzysztof Kozlowski
2024-05-16 17:13 ` Lucas Stach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®