mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Faiz Abbas <a0230074@ti.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
	Faiz Abbas <faiz_abbas@ti.com>, <linux-kernel@vger.kernel.org>,
	<linux-mmc@vger.kernel.org>
Cc: <ulf.hansson@linaro.org>
Subject: Re: [PATCH 1/2] mmc: sdhci_am654: Fix minor phy configurations
Date: Tue, 7 May 2019 21:59:06 +0530	[thread overview]
Message-ID: <2c867970-1255-b11f-9edf-ff002b7cea58@ti.com> (raw)
In-Reply-To: <8317e8a0-1b1f-4b0d-8a9b-2a6fdd0ab4e5@intel.com>

Hi Adrian,

On 26/04/19 11:20 AM, Adrian Hunter wrote:
> On 25/04/19 6:57 PM, Faiz Abbas wrote:
>> Fix the following minor things:
>>
>> 1. Line wrapping with the regmap_*() functions is way more conservative
>> than required by the 80 character rule. Expand the function calls out to
>> use less number of lines.
>>
>> 2. Add an error message if the DLL fails to lock.
> 
> Please make the white space changes a separate patch.
> 
> Also I would prefer not to use "fix" in the subject unless the patch fixes
> driver behaviour.
> 

Ok. Two different patches. No "fix" in the subject. Sending v2.

Thanks,
Faiz

  reply	other threads:[~2019-05-07 16:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-25 15:57 [PATCH 0/2] Fix issues with " Faiz Abbas
2019-04-25 15:57 ` [PATCH 1/2] mmc: sdhci_am654: Fix minor " Faiz Abbas
2019-04-26  5:50   ` Adrian Hunter
2019-05-07 16:29     ` Faiz Abbas [this message]
2019-04-25 15:57 ` [PATCH 2/2] mmc: sdhci_am654: Fix SLOTTYPE write Faiz Abbas
2019-04-26  6:00   ` Adrian Hunter
2019-05-07 16:27     ` Faiz Abbas
2019-05-08  6:04       ` Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c867970-1255-b11f-9edf-ff002b7cea58@ti.com \
    --to=a0230074@ti.com \
    --cc=adrian.hunter@intel.com \
    --cc=faiz_abbas@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®