From: Adrian Hunter <adrian.hunter@intel.com>
To: Faiz Abbas <a0230074@ti.com>, Faiz Abbas <faiz_abbas@ti.com>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Cc: ulf.hansson@linaro.org
Subject: Re: [PATCH 2/2] mmc: sdhci_am654: Fix SLOTTYPE write
Date: Wed, 8 May 2019 09:04:20 +0300 [thread overview]
Message-ID: <755f5c9f-922b-4f29-982a-cc411897b063@intel.com> (raw)
In-Reply-To: <db0b0790-4556-8a3b-2ae1-fcb4b1beb4b3@ti.com>
On 7/05/19 7:27 PM, Faiz Abbas wrote:
> Hi Adrian,
>
> On 26/04/19 11:30 AM, Adrian Hunter wrote:
>> On 25/04/19 6:57 PM, Faiz Abbas wrote:
>>> In the call to regmap_update_bits() for SLOTTYPE, the mask and value
>>> fields are exchanged. Fix this.
>>
>> Could you also comment on whether this has any known effect on the driver.
>>
>
> This call was basically a NOP but it was the correct way around in
> u-boot so it was just taking that value instead. No effect that was
> known to me. Found this out just by inspection.
Please put that in the commit message.
prev parent reply other threads:[~2019-05-08 6:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 15:57 [PATCH 0/2] Fix issues with phy configurations Faiz Abbas
2019-04-25 15:57 ` [PATCH 1/2] mmc: sdhci_am654: Fix minor " Faiz Abbas
2019-04-26 5:50 ` Adrian Hunter
2019-05-07 16:29 ` Faiz Abbas
2019-04-25 15:57 ` [PATCH 2/2] mmc: sdhci_am654: Fix SLOTTYPE write Faiz Abbas
2019-04-26 6:00 ` Adrian Hunter
2019-05-07 16:27 ` Faiz Abbas
2019-05-08 6:04 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=755f5c9f-922b-4f29-982a-cc411897b063@intel.com \
--to=adrian.hunter@intel.com \
--cc=a0230074@ti.com \
--cc=faiz_abbas@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®