From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: "Alexander Usyskin" <alexander.usyskin@intel.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Tvrtko Ursulin" <tursulin@ursulin.net>,
"Karthik Poosa" <karthik.poosa@intel.com>
Cc: Reuven Abliyev <reuven.abliyev@intel.com>,
Oren Weil <oren.jer.weil@intel.com>,
linux-mtd@lists.infradead.org, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Tomas Winkler <tomasw@gmail.com>
Subject: Re: [PATCH v4 02/11] mtd: add driver for intel graphics non-volatile memory device
Date: Thu, 2 Jan 2025 11:32:25 +0100 [thread overview]
Message-ID: <2c89e56d-26e9-4ef6-9da3-4b0121163b30@wanadoo.fr> (raw)
In-Reply-To: <20250101153925.865703-3-alexander.usyskin@intel.com>
Le 01/01/2025 à 16:39, Alexander Usyskin a écrit :
> Add auxiliary driver for intel discrete graphics
> non-volatile memory device.
>
> CC: Lucas De Marchi <lucas.demarchi@intel.com>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Co-developed-by: Tomas Winkler <tomasw@gmail.com>
> Signed-off-by: Tomas Winkler <tomasw@gmail.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
...
> +struct intel_dg_nvm {
> + struct kref refcnt;
> + void __iomem *base;
> + size_t size;
> + unsigned int nregions;
> + struct {
> + const char *name;
> + u8 id;
> + u64 offset;
> + u64 size;
> + } regions[];
__counted_by(nregions)?
> +};
> +
> +static void intel_dg_nvm_release(struct kref *kref)
> +{
> + struct intel_dg_nvm *nvm = container_of(kref, struct intel_dg_nvm, refcnt);
> + int i;
> +
> + pr_debug("freeing intel_dg nvm\n");
> + for (i = 0; i < nvm->nregions; i++)
> + kfree(nvm->regions[i].name);
> + kfree(nvm);
> +}
> +
> +static int intel_dg_mtd_probe(struct auxiliary_device *aux_dev,
> + const struct auxiliary_device_id *aux_dev_id)
> +{
> + struct intel_dg_nvm_dev *invm = auxiliary_dev_to_intel_dg_nvm_dev(aux_dev);
> + struct device *device;
> + struct intel_dg_nvm *nvm;
> + unsigned int nregions;
> + unsigned int i, n;
> + size_t size;
> + char *name;
> + int ret;
> +
> + device = &aux_dev->dev;
> +
> + /* count available regions */
> + for (nregions = 0, i = 0; i < INTEL_DG_NVM_REGIONS; i++) {
> + if (invm->regions[i].name)
> + nregions++;
> + }
> +
> + if (!nregions) {
> + dev_err(device, "no regions defined\n");
> + return -ENODEV;
> + }
> +
> + size = sizeof(*nvm) + sizeof(nvm->regions[0]) * nregions;
struct_size()? (and maybe no need for size)
> + nvm = kzalloc(size, GFP_KERNEL);
> + if (!nvm)
> + return -ENOMEM;
> +
> + kref_init(&nvm->refcnt);
> +
> + nvm->nregions = nregions;
> + for (n = 0, i = 0; i < INTEL_DG_NVM_REGIONS; i++) {
> + if (!invm->regions[i].name)
> + continue;
> +
> + name = kasprintf(GFP_KERNEL, "%s.%s",
> + dev_name(&aux_dev->dev), invm->regions[i].name);
> + if (!name)
> + continue;
> + nvm->regions[n].name = name;
> + nvm->regions[n].id = i;
> + n++;
> + }
Should we set the exact number of regions, should a kasprintf() fail?
nvm->nregions = n;
This would make __counted_by be more accurate in its check.
> +
> + nvm->base = devm_ioremap_resource(device, &invm->bar);
> + if (IS_ERR(nvm->base)) {
> + dev_err(device, "mmio not mapped\n");
> + ret = PTR_ERR(nvm->base);
> + goto err;
> + }
> +
> + dev_set_drvdata(&aux_dev->dev, nvm);
> +
> + return 0;
> +
> +err:
> + kref_put(&nvm->refcnt, intel_dg_nvm_release);
> + return ret;
> +}
...
CJ
next prev parent reply other threads:[~2025-01-02 10:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-01 15:39 [PATCH v4 00/11] mtd: add driver for Intel discrete graphics Alexander Usyskin
2025-01-01 15:39 ` [PATCH v4 01/11] mtd: core: always create master device Alexander Usyskin
2025-01-06 10:46 ` Miquel Raynal
2025-01-06 11:03 ` Usyskin, Alexander
2025-01-14 14:05 ` Usyskin, Alexander
2025-01-15 19:22 ` Miquel Raynal
2025-01-15 22:30 ` Richard Weinberger
2025-01-16 6:54 ` Usyskin, Alexander
2025-01-17 22:27 ` Richard Weinberger
2025-01-19 7:30 ` Usyskin, Alexander
2025-01-01 15:39 ` [PATCH v4 02/11] mtd: add driver for intel graphics non-volatile memory device Alexander Usyskin
2025-01-02 10:32 ` Christophe JAILLET [this message]
2025-01-02 13:20 ` Usyskin, Alexander
2025-01-01 15:39 ` [PATCH v4 03/11] mtd: intel-dg: implement region enumeration Alexander Usyskin
2025-01-02 10:37 ` Christophe JAILLET
2025-01-02 10:49 ` Usyskin, Alexander
2025-01-01 15:39 ` [PATCH v4 04/11] mtd: intel-dg: implement access functions Alexander Usyskin
2025-01-01 15:39 ` [PATCH v4 05/11] mtd: intel-dg: register with mtd Alexander Usyskin
2025-01-01 15:39 ` [PATCH v4 06/11] mtd: intel-dg: align 64bit read and write Alexander Usyskin
2025-01-01 16:41 ` David Laight
2025-01-01 21:16 ` David Laight
2025-01-02 13:56 ` Usyskin, Alexander
2025-01-01 15:39 ` [PATCH v4 07/11] mtd: intel-dg: wake card on operations Alexander Usyskin
2025-01-29 21:51 ` Rodrigo Vivi
2025-02-11 5:32 ` Poosa, Karthik
2025-02-12 14:15 ` Usyskin, Alexander
2025-01-01 15:39 ` [PATCH v4 08/11] drm/i915/nvm: add nvm device for discrete graphics Alexander Usyskin
2025-01-01 15:39 ` [PATCH v4 09/11] drm/i915/nvm: add support for access mode Alexander Usyskin
2025-01-01 15:39 ` [PATCH v4 10/11] drm/xe/nvm: add on-die non-volatile memory device Alexander Usyskin
2025-01-29 21:36 ` Rodrigo Vivi
2025-01-01 15:39 ` [PATCH v4 11/11] drm/xe/nvm: add support for access mode Alexander Usyskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c89e56d-26e9-4ef6-9da3-4b0121163b30@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=airlied@gmail.com \
--cc=alexander.usyskin@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=karthik.poosa@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lucas.demarchi@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=mripard@kernel.org \
--cc=oren.jer.weil@intel.com \
--cc=reuven.abliyev@intel.com \
--cc=richard@nod.at \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tomasw@gmail.com \
--cc=tursulin@ursulin.net \
--cc=tzimmermann@suse.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®