Re: [PATCH 09/24] scsi-multipath: failover handling

[John Garry <john.g.garry@oracle.com>]

On 04/03/2026 05:46, Benjamin Marzinski wrote:
>> +
>> +int scsi_mpath_failover_disposition(struct scsi_cmnd *scmd)
>> +{
>> +	struct request *req = scsi_cmd_to_rq(scmd);
>> +
>> +	if (is_mpath_request(req)) {
>> +		if (scsi_is_mpath_error(scmd) ||
>> +		    blk_queue_dying(req->q))
>> +			return FAILOVER;
>> +		return NEEDS_RETRY;
>> +	} else {
> nitpick: this else block is unnecessary.

Sure, but I will prob be changing this code anyway.

Cheers