[PATCH] sh: Use generic OHCI platform provider symbol

[PATCH] sh: Use generic OHCI platform provider symbol

[Pengpeng Hou]

The old SuperH-specific `USB_OHCI_SH` provider symbol no longer carries
an OHCI provider object.  The current platform OHCI provider is
`USB_OHCI_HCD_PLATFORM`, which builds ohci-platform.o.

Several SH CPU subtypes still select `USB_OHCI_SH`, and the
sh7757lcr defconfig still enables it directly.  Switch both the subtype
selects and the defconfig to `USB_OHCI_HCD_PLATFORM` so the intended OHCI
provider remains reachable when `USB_OHCI_HCD` is enabled.

Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
---
 arch/sh/Kconfig                  | 8 ++++----
 arch/sh/configs/sh7757lcr_defconfig | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
--- a/arch/sh/Kconfig
+++ b/arch/sh/Kconfig
@@ -331,7 +331,7 @@ config CPU_SUBTYPE_SH7720
 	select CPU_SH3
 	select CPU_HAS_DSP
 	select SYS_SUPPORTS_SH_CMT
-	select USB_OHCI_SH if USB_OHCI_HCD
+	select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
 	select PINCTRL
 	help
 	  Select SH7720 if you have a SH3-DSP SH7720 CPU.
@@ -341,6 +341,6 @@ config CPU_SUBTYPE_SH7721
 	bool "Support SH7721 processor"
 	select CPU_SH3
 	select CPU_HAS_DSP
-	select USB_OHCI_SH if USB_OHCI_HCD
+	select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
 	help
 	  Select SH7721 if you have a SH3-DSP SH7721 CPU.
@@ -426,5 +426,5 @@ config CPU_SUBTYPE_SH7763
 	bool "Support SH7763 processor"
 	select CPU_SH4A
-	select USB_OHCI_SH if USB_OHCI_HCD
+	select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
 	help
 	  Select SH7763 if you have a SH4A SH7763(R5S77631) CPU.
@@ -452,5 +452,5 @@ config CPU_SUBTYPE_SH7786
 	select CPU_HAS_PTEAEX
 	select GENERIC_CLOCKEVENTS_BROADCAST if SMP
-	select USB_OHCI_SH if USB_OHCI_HCD
+	select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
 	select USB_EHCI_SH if USB_EHCI_HCD
 	select PINCTRL
diff --git a/arch/sh/configs/sh7757lcr_defconfig b/arch/sh/configs/sh7757lcr_defconfig
--- a/arch/sh/configs/sh7757lcr_defconfig
+++ b/arch/sh/configs/sh7757lcr_defconfig
@@ -58,8 +58,8 @@ CONFIG_HWMON is not set
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_EHCI_SH=y
 CONFIG_USB_OHCI_HCD=y
-CONFIG_USB_OHCI_SH=y
+CONFIG_USB_OHCI_HCD_PLATFORM=y
 CONFIG_USB_STORAGE=y
 CONFIG_MMC=y
 CONFIG_MMC_SDHI=y

Re: [PATCH] sh: Use generic OHCI platform provider symbol

[Geert Uytterhoeven]

On Wed, 24 Jun 2026 at 19:56, Pengpeng Hou <pengpeng@iscas.ac.cn> wrote:
> The old SuperH-specific `USB_OHCI_SH` provider symbol no longer carries
> an OHCI provider object.  The current platform OHCI provider is
> `USB_OHCI_HCD_PLATFORM`, which builds ohci-platform.o.
>
> Several SH CPU subtypes still select `USB_OHCI_SH`, and the
> sh7757lcr defconfig still enables it directly.  Switch both the subtype
> selects and the defconfig to `USB_OHCI_HCD_PLATFORM` so the intended OHCI
> provider remains reachable when `USB_OHCI_HCD` is enabled.
>
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>

Fixes: 4f6dfc2136fb2e8d ("usb: remove the dead USB_OHCI_SH option")
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

It's a pity people sometimes don't take into account review comments
before applying patches...
https://lore.kernel.org/CAMuHMdVM3BpvVD3c4gp1OidnwF5zFd4MJecij7zWBnahzNaSNw@mail.gmail.com/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] sh: Use generic OHCI platform provider symbol

[Pengpeng Hou]

Hi Geert,

I checked the removal of USB_OHCI_SH. Please include the tag you supplied:

Fixes: 4f6dfc2136fb ("usb: remove the dead USB_OHCI_SH option")

The current SH subtype selections and sh7757lcr_defconfig still name the
removed symbol. The patch switches those users to USB_OHCI_HCD_PLATFORM;
there is no additional code change for this metadata update.

Thanks,
Pengpeng

Re: [PATCH] sh: Use generic OHCI platform provider symbol

[John Paul Adrian Glaubitz]

Hi Pengpeng,

On Sun, 2026-09-20 at 11:11 +0800, Pengpeng Hou wrote:
> Hi Geert,
> 
> I checked the removal of USB_OHCI_SH. Please include the tag you supplied:
> 
> Fixes: 4f6dfc2136fb ("usb: remove the dead USB_OHCI_SH option")
> 
> The current SH subtype selections and sh7757lcr_defconfig still name the
> removed symbol. The patch switches those users to USB_OHCI_HCD_PLATFORM;
> there is no additional code change for this metadata update.

Shall I use the v2 by Karl or are you going to send another one?

I am currently collecting patches which I am going to send to Linus
for v7.4.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913