mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chao Yu <yuchao0@huawei.com>
To: Pan Bian <bianpan2016@163.com>, Jaegeuk Kim <jaegeuk@kernel.org>
Cc: <linux-f2fs-devel@lists.sourceforge.net>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] f2fs: read page index before freeing
Date: Thu, 22 Nov 2018 19:21:16 +0800	[thread overview]
Message-ID: <2cd91c95-598d-fcc1-b1d6-6fddb224efcf@huawei.com> (raw)
In-Reply-To: <1542884326-74903-1-git-send-email-bianpan2016@163.com>

Hi Pan,

On 2018/11/22 18:58, Pan Bian wrote:
> The function truncate_node frees the page with f2fs_put_page. However,
> the page index is read after that. So, the patch reads the index before
> freeing the page.

Good catch!

It will be better to add:

Fixes: bf39c00a9a7f ("f2fs: drop obsolete node page when it is truncated")
Cc: <stable@vger.kernel.org>

> 
> Signed-off-by: Pan Bian <bianpan2016@163.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,


  reply	other threads:[~2018-11-22 11:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-22 10:58 Pan Bian
2018-11-22 11:21 ` Chao Yu [this message]
2018-11-22 12:02   ` Jaegeuk Kim
2018-11-26  9:13 ` Chao Yu
2018-11-26 10:28   ` PanBian
2018-11-26 11:07     ` Chao Yu
2018-11-27  0:22       ` PanBian
2018-11-27  3:12         ` Chao Yu
2018-11-27  3:22           ` PanBian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2cd91c95-598d-fcc1-b1d6-6fddb224efcf@huawei.com \
    --to=yuchao0@huawei.com \
    --cc=bianpan2016@163.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®