mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vasant Hegde <vasant.hegde@amd.com>
To: Baolu Lu <baolu.lu@linux.intel.com>, Jason Gunthorpe <jgg@nvidia.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Kevin Tian <kevin.tian@intel.com>, Jann Horn <jannh@google.com>,
	Dave Hansen <dave.hansen@intel.com>,
	Alistair Popple <apopple@nvidia.com>,
	Uladzislau Rezki <urezki@gmail.com>,
	Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Andy Lutomirski <luto@kernel.org>,
	"Tested-by : Yi Lai" <yi1.lai@intel.com>,
	iommu@lists.linux.dev, security@kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 1/1] iommu/sva: Invalidate KVA range on kernel TLB flush
Date: Thu, 17 Jul 2025 17:20:07 +0530	[thread overview]
Message-ID: <2cd924f0-ad19-4b29-b637-c1ff2dd68cbc@amd.com> (raw)
In-Reply-To: <df5353e2-1d54-476b-90ab-e673686dcc41@linux.intel.com>

Hi Lu, Jason,


On 7/17/2025 7:13 AM, Baolu Lu wrote:
> On 7/16/25 20:08, Jason Gunthorpe wrote:
>> On Wed, Jul 16, 2025 at 02:34:04PM +0800, Baolu Lu wrote:
>>>>> @@ -654,6 +656,9 @@ struct iommu_ops {
>>>>>
>>>>>        int (*def_domain_type)(struct device *dev);
>>>>>
>>>>> +    void (*paging_cache_invalidate)(struct iommu_device *dev,
>>>>> +                    unsigned long start, unsigned long end);
>>>>
>>>> How would you even implement this in a driver?
>>>>
>>>> You either flush the whole iommu, in which case who needs a rage, or
>>>> the driver has to iterate over the PASID list, in which case it
>>>> doesn't really improve the situation.
>>>
>>> The Intel iommu driver supports flushing all SVA PASIDs with a single
>>> request in the invalidation queue.
>>
>> How? All PASID !=0 ? The HW has no notion about a SVA PASID vs no-SVA
>> else. This is just flushing almost everything.
> 
> The intel iommu driver allocates a dedicated domain id for all sva
> domains. It can flush all cache entries with that domain id tagged.

AMD IOMMU has INVALIDATE_IOMMU_ALL which flushes everything in IOMMU TLB. This
is heavy hammer. But should be OK for short term solution?

I don't think this command is supported inside the guest (I will double check).
But we don't have HW-vIOMMU support yet. So PASID inside guest is not yet supported.


-Vasant




  reply	other threads:[~2025-07-17 11:50 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-09  6:28 Lu Baolu
2025-07-09 15:29 ` Dave Hansen
2025-07-10  2:14   ` Baolu Lu
2025-07-10  2:55     ` Tian, Kevin
2025-07-10 12:53     ` Dave Hansen
2025-07-10 13:22       ` Jason Gunthorpe
2025-07-10 15:26         ` Dave Hansen
2025-07-11  2:46           ` Tian, Kevin
2025-07-11  2:54           ` Tian, Kevin
2025-07-11  8:17           ` Yu Zhang
2025-07-24  3:01             ` Baolu Lu
2025-07-28 17:36               ` Yu Zhang
2025-07-29  2:08                 ` Baolu Lu
2025-07-24  3:06           ` Baolu Lu
2025-07-11  2:49         ` Tian, Kevin
2025-07-10  3:02 ` Tian, Kevin
2025-07-10  8:11   ` Yu Zhang
2025-07-10  8:15     ` Tian, Kevin
2025-07-10  9:37       ` Yu Zhang
2025-07-10 13:54 ` Peter Zijlstra
2025-07-10 15:53   ` Peter Zijlstra
2025-07-11  3:09     ` Baolu Lu
2025-07-11  8:27       ` Peter Zijlstra
2025-07-16 11:57     ` David Laight
2025-07-17  1:47       ` Baolu Lu
2025-07-11  3:00   ` Baolu Lu
2025-07-11  4:01     ` Tian, Kevin
2025-07-11  8:32     ` Peter Zijlstra
2025-07-11 11:58       ` Jason Gunthorpe
2025-07-15  5:55       ` Baolu Lu
2025-07-15 12:25         ` Jason Gunthorpe
2025-07-16  6:34           ` Baolu Lu
2025-07-16 12:08             ` Jason Gunthorpe
2025-07-17  1:43               ` Baolu Lu
2025-07-17 11:50                 ` Vasant Hegde [this message]
2025-07-11 11:54     ` Jason Gunthorpe
2025-07-16 10:54 ` Yi Liu
2025-07-17  1:51   ` Baolu Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2cd924f0-ad19-4b29-b637-c1ff2dd68cbc@amd.com \
    --to=vasant.hegde@amd.com \
    --cc=apopple@nvidia.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=dave.hansen@intel.com \
    --cc=iommu@lists.linux.dev \
    --cc=jannh@google.com \
    --cc=jean-philippe@linaro.org \
    --cc=jgg@nvidia.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=peterz@infradead.org \
    --cc=robin.murphy@arm.com \
    --cc=security@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=urezki@gmail.com \
    --cc=will@kernel.org \
    --cc=yi1.lai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®