From: aviyae <aviyae42@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: goldfish: Add parenthesis around macros arguments
Date: Thu, 30 Mar 2017 00:11:05 +0300 [thread overview]
Message-ID: <2cf02d91-9ad5-164e-24fd-f76e86b277ec@gmail.com> (raw)
In-Reply-To: <cd914524-d22e-faa4-44a4-c705b298a385@gmail.com>
Fix style issues by adding parenthesis around macros
arguments
Signed-off-by: Aviya Erenfeld <aviyae42@gmail.com>
---
drivers/staging/goldfish/goldfish_audio.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c
index bd55995..2bb1f27 100644
--- a/drivers/staging/goldfish/goldfish_audio.c
+++ b/drivers/staging/goldfish/goldfish_audio.c
@@ -61,10 +61,11 @@ struct goldfish_audio {
#define COMBINED_BUFFER_SIZE ((2 * READ_BUFFER_SIZE) + \
(2 * WRITE_BUFFER_SIZE))
-#define AUDIO_READ(data, addr) (readl(data->reg_base + addr))
-#define AUDIO_WRITE(data, addr, x) (writel(x, data->reg_base + addr))
+#define AUDIO_READ(data, addr) (readl((data)->reg_base + (addr)))
+#define AUDIO_WRITE(data, addr, x) (writel(x, (data)->reg_base + (addr)))
#define AUDIO_WRITE64(data, addr, addr2, x) \
- (gf_write_dma_addr((x), data->reg_base + addr, data->reg_base + addr2))
+ (gf_write_dma_addr((x), (data)->reg_base + (addr), \
+ (data)->reg_base + (addr2)))
/*
* temporary variable used between goldfish_audio_probe() and
--
2.7.4
next prev parent reply other threads:[~2017-03-29 21:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 9:53 [PATCH] staging: goldfish: Fix coding style issues aviyae
2017-03-27 10:04 ` Greg KH
2017-03-27 11:52 ` [PATCH v2] staging: goldfish: Fix style issues in macros aviyae
2017-03-27 12:05 ` Frans Klaver
2017-03-27 12:13 ` aviyae
2017-03-27 12:19 ` Frans Klaver
2017-03-27 12:19 ` [PATCH v3] " aviyae
2017-03-29 7:19 ` Greg KH
2017-03-29 21:11 ` aviyae [this message]
2017-04-08 15:03 ` [PATCH] staging: goldfish: Add parenthesis around macros arguments Greg KH
2017-04-08 15:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cf02d91-9ad5-164e-24fd-f76e86b277ec@gmail.com \
--to=aviyae42@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®