From: aviyae <aviyae42@gmail.com>
To: Frans Klaver <fransklaver@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] staging: goldfish: Fix style issues in macros
Date: Mon, 27 Mar 2017 15:13:53 +0300 [thread overview]
Message-ID: <490f2ef9-d1d7-6d69-4b6c-7ad5ae44f209@gmail.com> (raw)
In-Reply-To: <CAH6sp9P3XYixi_QFQ9b_UdF58yxGbgvOUr4uJHJzVw91FH5J_g@mail.gmail.com>
I'll remove that eudyptula thing, although there are some patches that mention it
(run git log --grep=eudyptula)
On 27/03/17 15:05, Frans Klaver wrote:
> On Mon, Mar 27, 2017 at 1:52 PM, aviyae <aviyae42@gmail.com> wrote:
>> From: Aviya Erenfeld <aviyae42@gmail.com>
>>
>> staging: goldfish: Fix style issues in macros
>>
>> Fix coding style issues in macros:
>> 1. Add parenthesis around macros argument
>> 2. Avoid arguments reuse in macros
>>
>> (For the eudyptula challenge)
> How is that relevant?
>
> Frans
next prev parent reply other threads:[~2017-03-27 12:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 9:53 [PATCH] staging: goldfish: Fix coding style issues aviyae
2017-03-27 10:04 ` Greg KH
2017-03-27 11:52 ` [PATCH v2] staging: goldfish: Fix style issues in macros aviyae
2017-03-27 12:05 ` Frans Klaver
2017-03-27 12:13 ` aviyae [this message]
2017-03-27 12:19 ` Frans Klaver
2017-03-27 12:19 ` [PATCH v3] " aviyae
2017-03-29 7:19 ` Greg KH
2017-03-29 21:11 ` [PATCH] staging: goldfish: Add parenthesis around macros arguments aviyae
2017-04-08 15:03 ` Greg KH
2017-04-08 15:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490f2ef9-d1d7-6d69-4b6c-7ad5ae44f209@gmail.com \
--to=aviyae42@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=fransklaver@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®