From: Xin Xie <xiexinet@gmail.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, andrew+netdev@lunn.ch, shuah@kernel.org,
kees@kernel.org, petr.wozniak@gmail.com, qingfang.deng@linux.dev,
fmaurer@redhat.com, luka.gejak@linux.dev,
xiaoliang.yang_1@nxp.com, skhawaja@google.com,
liuhangbin@gmail.com, stable@vger.kernel.org,
sdf.kernel@gmail.com
Subject: Re: [PATCH 3/4] net: hsr: unfold GSO super-packets at the forward entry
Date: Thu, 24 Sep 2026 23:26:27 +0200 [thread overview]
Message-ID: <2cf54664-c07d-471f-af6d-4b70e09626b4@gmail.com> (raw)
In-Reply-To: <20260923104346.ur63K3h2@linutronix.de>
On 23/09/2026 12:43, Sebastian Andrzej Siewior wrote:
> Wouldn't it be simpler to not allow such packets?
For master TX, yes: removing GSO features lets the core segment before
ndo_start_xmit(), as patch 3 already does.
The interlink RX path is different. With GRO/GRO_HW disabled, it can
still receive skbs that were already GSO at the sender. I reproduced
this with ordinary TCP traffic over veth in a VM. Rejecting these skbs
would drop valid traffic.
I'll retain segmentation for valid interlink GSO in the ordered
consumer described in my patch 2 reply, before per-frame sequence
allocation and HSR tag/PRP RCT construction. Each aggregate would finish
before the next input, without holding an HSR lock across segmentation
or transmission.
--
Xin
next prev parent reply other threads:[~2026-09-24 21:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-09 12:14 [PATCH net v6 0/4] net: hsr: fix GRO/GSO super-packet handling Xin Xie
2026-08-09 12:14 ` [PATCH 1/4] net: hsr: fix packet drops caused by GRO superpackets Xin Xie
2026-08-14 1:21 ` Jakub Kicinski
2026-08-17 15:38 ` Xin Xie
2026-09-18 23:46 ` Xin Xie
2026-09-23 10:32 ` Sebastian Andrzej Siewior
2026-09-24 21:16 ` Xin Xie
2026-08-09 12:14 ` [PATCH 2/4] net: hsr: shrink seqnr_lock to sequence counter updates Xin Xie
2026-08-10 2:23 ` Hangbin Liu
2026-09-23 10:37 ` Sebastian Andrzej Siewior
2026-09-24 21:22 ` Xin Xie
2026-08-09 12:14 ` [PATCH 3/4] net: hsr: unfold GSO super-packets at the forward entry Xin Xie
2026-09-23 10:43 ` Sebastian Andrzej Siewior
2026-09-24 21:26 ` Xin Xie [this message]
2026-08-09 12:14 ` [PATCH 4/4] selftests: net: hsr: cover GSO super-packets on PRP slave ingress Xin Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cf54664-c07d-471f-af6d-4b70e09626b4@gmail.com \
--to=xiexinet@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fmaurer@redhat.com \
--cc=horms@kernel.org \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=luka.gejak@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petr.wozniak@gmail.com \
--cc=qingfang.deng@linux.dev \
--cc=sdf.kernel@gmail.com \
--cc=shuah@kernel.org \
--cc=skhawaja@google.com \
--cc=stable@vger.kernel.org \
--cc=xiaoliang.yang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®