mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Goran Rađenović" <goran.radni@gmail.com>
Cc: "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Börge Strümpfel" <boerge.struempfel@gmail.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 4/4] ARM: dts: stm32: add initial support for stm32mp157-ultra-fly-sbc board
Date: Mon, 5 May 2025 18:26:47 +0200	[thread overview]
Message-ID: <2d0ff289-06f6-4bde-a238-097d22573d4e@lunn.ch> (raw)
In-Reply-To: <20250505115827.29593-5-goran.radni@gmail.com>

> +&ethernet0 {
> +	status = "okay";
> +	pinctrl-0 = <&ethernet0_ux_rgmii_pins_a>;
> +	pinctrl-1 = <&ethernet0_ux_rgmii_pins_sleep_a>;
> +	pinctrl-names = "default", "sleep";
> +	phy-mode = "rgmii-id";
> +	max-speed = <1000>;

max-speed is probably pointless, rgmii cannot do more than 1G.

> +	phy-handle = <&phy1>;
> +
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		compatible = "snps,dwmac-mdio";
> +		phy1: ethernet-phy@1 {
> +			reg = <1>;
> +			interrupt-parent = <&gpiod>;
> +			interrupts = <0 IRQ_TYPE_EDGE_FALLING>;

PHY interrupts are 99% time level, not edge.

	Andrew

  reply	other threads:[~2025-05-05 16:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250505115827.29593-1-goran.radni@gmail.com>
2025-05-05 11:58 ` [PATCH v5 1/4] dt-bindings: vendor-prefixes: Add Ultratronik Goran Rađenović
2025-05-05 11:58 ` [PATCH v5 2/4] dt-bindings: arm: stm32: Document Ultratronik's Fly board DT binding Goran Rađenović
2025-05-05 11:58 ` [PATCH v5 3/4] MAINTAINERS: Add entry for ULTRATRONIK BOARD SUPPORT Goran Rađenović
2025-05-05 11:58 ` [PATCH v5 4/4] ARM: dts: stm32: add initial support for stm32mp157-ultra-fly-sbc board Goran Rađenović
2025-05-05 16:26   ` Andrew Lunn [this message]
2025-05-07 11:06     ` Goran Radenovic
2025-05-07 12:53       ` Andrew Lunn
2025-05-08 13:10         ` Goran Radenovic
2025-05-08 13:51           ` Andrew Lunn
2025-05-12  9:45           ` Alexandre TORGUE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d0ff289-06f6-4bde-a238-097d22573d4e@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=alexandre.torgue@foss.st.com \
    --cc=boerge.struempfel@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=goran.radni@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®