[PATCH] EDAC, layerscape: allow building for LS1021A

[PATCH] EDAC, layerscape: allow building for LS1021A

[Rasmus Villemoes]

The LS1021A has a memory controller supported by this driver. It builds
just fine, and I've done some rudimentary testing using the error
injection facility, which suggests that it is indeed working.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
---
Hi York

In https://patchwork.kernel.org/patch/9264623/, you wrote that LS1021A
support is "just one step away". I'm wondering if this is simply that
step, or there is a little more to it. As I write, it seems to work
just fine, but I may be missing something.

 drivers/edac/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
index 96afb2aeed18..23f619afe31d 100644
--- a/drivers/edac/Kconfig
+++ b/drivers/edac/Kconfig
@@ -254,7 +254,7 @@ config EDAC_MPC85XX
 
 config EDAC_LAYERSCAPE
 	tristate "Freescale Layerscape DDR"
-	depends on ARCH_LAYERSCAPE
+	depends on ARCH_LAYERSCAPE || SOC_LS1021A
 	help
 	  Support for error detection and correction on Freescale memory
 	  controllers on Layerscape SoCs.
-- 
2.15.1

Re: [PATCH] EDAC, layerscape: allow building for LS1021A

[York Sun]

Sorry for top posting. I am on vacation and replying from my phone.

The controller is compatible and the driver should work. Please double check to make sure you can inject errors and receive interrupt. After that you are good to go.

York

Sent from my iPhone

> On Feb 20, 2018, at 23:09, Rasmus Villemoes <rasmus.villemoes@prevas.dk> wrote:
> 
> The LS1021A has a memory controller supported by this driver. It builds
> just fine, and I've done some rudimentary testing using the error
> injection facility, which suggests that it is indeed working.
> 
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> ---
> Hi York
> 
> In https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fpatch%2F9264623%2F&data=02%7C01%7Cyork.sun%40nxp.com%7C08fea717f1ca406b5db608d57873ed51%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636547361667697520&sdata=j%2Ff9myWudDTi38NQCBVv5yX5h%2F2TqcO10yTvcg%2FPWVM%3D&reserved=0, you wrote that LS1021A
> support is "just one step away". I'm wondering if this is simply that
> step, or there is a little more to it. As I write, it seems to work
> just fine, but I may be missing something.
> 
> drivers/edac/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
> index 96afb2aeed18..23f619afe31d 100644
> --- a/drivers/edac/Kconfig
> +++ b/drivers/edac/Kconfig
> @@ -254,7 +254,7 @@ config EDAC_MPC85XX
> 
> config EDAC_LAYERSCAPE
>    tristate "Freescale Layerscape DDR"
> -    depends on ARCH_LAYERSCAPE
> +    depends on ARCH_LAYERSCAPE || SOC_LS1021A
>    help
>      Support for error detection and correction on Freescale memory
>      controllers on Layerscape SoCs.
> -- 
> 2.15.1
> 

Re: [PATCH] EDAC, layerscape: allow building for LS1021A

[Rasmus Villemoes]

On 2018-02-20 22:01, York Sun wrote:
> Sorry for top posting. I am on vacation and replying from my phone.
> 
> The controller is compatible and the driver should work. Please double check to make sure you can inject errors and receive interrupt. After that you are good to go.

I can indeed inject errors and get the interrupt.

Thanks,
Rasmus

Re: [PATCH] EDAC, layerscape: allow building for LS1021A

[York Sun]

Then you are good to go.

York

Sent from my iPhone

> On Feb 22, 2018, at 22:40, Rasmus Villemoes <rasmus.villemoes@prevas.dk> wrote:
> 
>> On 2018-02-20 22:01, York Sun wrote:
>> Sorry for top posting. I am on vacation and replying from my phone.
>> 
>> The controller is compatible and the driver should work. Please double check to make sure you can inject errors and receive interrupt. After that you are good to go.
> 
> I can indeed inject errors and get the interrupt.
> 
> Thanks,
> Rasmus

Re: [PATCH] EDAC, layerscape: allow building for LS1021A

[Rasmus Villemoes]

On 2018-02-22 22:22, York Sun wrote:
> Then you are good to go.

Great. Borislav, will you pick this up?

Rasmus

Re: [PATCH] EDAC, layerscape: allow building for LS1021A

[Borislav Petkov]

On Tue, Feb 27, 2018 at 12:58:23PM +0100, Rasmus Villemoes wrote:
> On 2018-02-22 22:22, York Sun wrote:
> > Then you are good to go.
> 
> Great. Borislav, will you pick this up?

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.