From: David Lechner <dlechner@baylibre.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>,
Moksh Panicker <mokshpanicker.7@gmail.com>
Cc: jic23@kernel.org, nuno.sa@analog.com,
Michael.Hennerich@analog.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org
Subject: Re: [PATCH 1/2] iio: adc: ad7779: Remove unused completion field
Date: Sun, 28 Jun 2026 09:34:00 -0500 [thread overview]
Message-ID: <2d478d88-807d-4eed-bcd1-a829d3cd12b6@baylibre.com> (raw)
In-Reply-To: <20260628134154.39236df8@systembl0wer>
On 6/28/26 6:41 AM, Joshua Crofts wrote:
> On Sun, 28 Jun 2026 07:14:04 +0000
> Moksh Panicker <mokshpanicker.7@gmail.com> wrote:
>
>> struct ad7779_state contains a completion field that is initialized
>> in ad7779_setup_without_backend() but never waited on or signaled
>> anywhere in the driver. Remove the dead code.
>>
>> Suggested-by: Joshua Crofts <joshua.crofts1@gmail.com>
>> Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
>> ---
>
> If you're sending a patch series, please use a cover letter (if
> you're using git send-email, add a cover letter with the
> `--cover-letter` flag) where you can describe your changes in
> detail, along with additional useful info (testing etc.)
Also, please don't send new series or revisions of a series in reply
to other series or previous revisions. It breaks existing workflows
and tooling.
>
> Nevertheless,
>
> Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
>
prev parent reply other threads:[~2026-06-28 14:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-27 11:22 [PATCH] iio: adc: ad7779: Initialize completion before requesting IRQ Moksh Panicker
2026-06-27 17:26 ` Joshua Crofts
2026-06-28 7:14 ` [PATCH 1/2] iio: adc: ad7779: Remove unused completion field Moksh Panicker
2026-06-28 7:14 ` [PATCH 2/2] iio: adc: ad7779: Remove redundant dev_err_probe() after devm_request_irq() Moksh Panicker
2026-06-28 11:42 ` Joshua Crofts
2026-06-28 11:41 ` [PATCH 1/2] iio: adc: ad7779: Remove unused completion field Joshua Crofts
2026-06-28 14:34 ` David Lechner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d478d88-807d-4eed-bcd1-a829d3cd12b6@baylibre.com \
--to=dlechner@baylibre.com \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mokshpanicker.7@gmail.com \
--cc=nuno.sa@analog.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome