From: Stefan Agner <stefan@agner.ch>
To: Felipe Balbi <balbi@kernel.org>, Greg KH <gregkh@linuxfoundation.org>
Cc: andrzej.p@samsung.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] fs: configfs: use hexadecimal values and new line
Date: Wed, 01 Feb 2017 08:51:54 -0800 [thread overview]
Message-ID: <2d492b1c2c0ccd45e14448bcc6d95cc1@agner.ch> (raw)
In-Reply-To: <87o9ym2sih.fsf@linux.intel.com>
On 2017-02-01 01:02, Felipe Balbi wrote:
> Hi,
>
> Greg KH <gregkh@linuxfoundation.org> writes:
>> On Tue, Jan 31, 2017 at 06:19:17PM -0800, Stefan Agner wrote:
>>> Other unsigned properties return hexadecimal values, follow this
>>> convention when printing b_vendor_code too. Also add newlines to
>>> the OS Descriptor support related properties, like other sysfs
>>> files use.
>>
>> configfs is not sysfs, so watch out, you might not need/want those new
>> lines as tools read the values and are not expecting them.
>>
>> Have you verified that nothing will break with this? How have you
>> tested it?
I am actually writing OS Descriptor support for libusbgx (fork of
libusbg) when I stumbled upon this. The helper function there do not
care about the new line, but I just thought we should fix it for the
sake of coherency to the other properties. I am also fine dropping this
patch.
>
> I would rather not change things like that, specially since Android guys
> are alreadying using configfs.
Do you happen to know where the source of that part is? So we could
check if they make use of any OS Descriptor support yet...
--
Stefan
next prev parent reply other threads:[~2017-02-01 16:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 2:19 [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric Stefan Agner
2017-02-01 2:19 ` [PATCH 2/2] fs: configfs: use hexadecimal values and new line Stefan Agner
2017-02-01 8:07 ` Greg KH
2017-02-01 9:02 ` Felipe Balbi
2017-02-01 16:51 ` Stefan Agner [this message]
2017-02-01 8:06 ` [PATCH 1/2] fs: configfs: make qw_sign attribute symmetric Greg KH
2017-02-01 16:59 ` Stefan Agner
2017-02-09 18:04 ` Stefan Agner
2017-02-10 11:19 ` Greg KH
2017-02-10 12:30 ` Felipe Balbi
2017-02-10 20:29 ` Stefan Agner
2017-02-13 10:46 ` Felipe Balbi
2017-02-01 8:07 ` Greg KH
2017-04-15 1:35 Stefan Agner
2017-04-15 1:35 ` [PATCH 2/2] fs: configfs: use hexadecimal values and new line Stefan Agner
2017-04-19 8:45 ` Krzysztof Opasiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d492b1c2c0ccd45e14448bcc6d95cc1@agner.ch \
--to=stefan@agner.ch \
--cc=andrzej.p@samsung.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome