From: "Christian König" <christian.koenig@amd.com>
To: "Colin King" <colin.king@canonical.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"David Airlie" <airlied@linux.ie>, "Rex Zhu" <Rex.Zhu@amd.com>,
"Nils Wallménius" <nils.wallmenius@gmail.com>,
dri-devel@lists.freedesktop.org
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][V2] drm/amd/powerplay: fix spelling mistake and add KERN_WARNING to printks
Date: Tue, 25 Oct 2016 09:43:20 +0200 [thread overview]
Message-ID: <2dbb0991-34d1-670d-b581-0cf59c8848ae@amd.com> (raw)
In-Reply-To: <20161024231412.11164-1-colin.king@canonical.com>
Am 25.10.2016 um 01:14 schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> Fix trivial spelling mistake cant't -> can't and add KERN_WARNING to
> printk messages. Remove redundant spaces before \n too (thanks to
> Joe Perches for spotting those).
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Christian König <christian.koenig@amd.com>.
> ---
> drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c | 4 ++--
> drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c | 4 ++--
> drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c | 4 ++--
> drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c | 4 ++--
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c
> index 76310ac..62e99d7 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c
> @@ -2125,7 +2125,7 @@ uint32_t fiji_get_offsetof(uint32_t type, uint32_t member)
> return offsetof(SMU73_Discrete_DpmTable, LowSclkInterruptThreshold);
> }
> }
> - printk("cant't get the offset of type %x member %x \n", type, member);
> + printk(KERN_WARNING "can't get the offset of type %x member %x\n", type, member);
> return 0;
> }
>
> @@ -2150,7 +2150,7 @@ uint32_t fiji_get_mac_definition(uint32_t value)
> return SMU73_MAX_LEVELS_MVDD;
> }
>
> - printk("cant't get the mac of %x \n", value);
> + printk(KERN_WARNING "can't get the mac of %x\n", value);
> return 0;
> }
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c
> index 8c889ca..0cc20a8 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c
> @@ -2140,7 +2140,7 @@ uint32_t iceland_get_offsetof(uint32_t type, uint32_t member)
> return offsetof(SMU71_Discrete_DpmTable, LowSclkInterruptThreshold);
> }
> }
> - printk("cant't get the offset of type %x member %x \n", type, member);
> + printk(KERN_WARNING "can't get the offset of type %x member %x\n", type, member);
> return 0;
> }
>
> @@ -2163,7 +2163,7 @@ uint32_t iceland_get_mac_definition(uint32_t value)
> return SMU71_MAX_LEVELS_MVDD;
> }
>
> - printk("cant't get the mac of %x \n", value);
> + printk(KERN_WARNING "can't get the mac of %x\n", value);
> return 0;
> }
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c
> index 4ccc0b7..7236c51 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c
> @@ -2174,7 +2174,7 @@ uint32_t polaris10_get_offsetof(uint32_t type, uint32_t member)
> return offsetof(SMU74_Discrete_DpmTable, LowSclkInterruptThreshold);
> }
> }
> - printk("cant't get the offset of type %x member %x \n", type, member);
> + printk(KERN_WARNING "can't get the offset of type %x member %x\n", type, member);
> return 0;
> }
>
> @@ -2201,7 +2201,7 @@ uint32_t polaris10_get_mac_definition(uint32_t value)
> return SMU7_UVD_MCLK_HANDSHAKE_DISABLE;
> }
>
> - printk("cant't get the mac of %x \n", value);
> + printk(KERN_WARNING "can't get the mac of %x\n", value);
> return 0;
> }
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c
> index de2a24d..d08f6f1 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c
> @@ -2651,7 +2651,7 @@ uint32_t tonga_get_offsetof(uint32_t type, uint32_t member)
> return offsetof(SMU72_Discrete_DpmTable, LowSclkInterruptThreshold);
> }
> }
> - printk("cant't get the offset of type %x member %x\n", type, member);
> + printk(KERN_WARNING "can't get the offset of type %x member %x\n", type, member);
> return 0;
> }
>
> @@ -2675,7 +2675,7 @@ uint32_t tonga_get_mac_definition(uint32_t value)
> case SMU_MAX_LEVELS_MVDD:
> return SMU72_MAX_LEVELS_MVDD;
> }
> - printk("cant't get the mac value %x\n", value);
> + printk(KERN_WARNING "can't get the mac value %x\n", value);
>
> return 0;
> }
next prev parent reply other threads:[~2016-10-25 7:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 23:14 Colin King
2016-10-25 7:43 ` Christian König [this message]
2016-10-25 15:28 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dbb0991-34d1-670d-b581-0cf59c8848ae@amd.com \
--to=christian.koenig@amd.com \
--cc=Rex.Zhu@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=colin.king@canonical.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nils.wallmenius@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®