From: Umang Jain <umang.jain@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
open list <linux-kernel@vger.kernel.org>,
Tommaso Merciai <tomm.merciai@gmail.com>
Subject: Re: [PATCH] media: imx335: Fix reset-gpio handling
Date: Mon, 29 Jul 2024 14:19:32 +0530 [thread overview]
Message-ID: <2dc31ed8-ad83-4051-8de3-6efaf1538714@ideasonboard.com> (raw)
In-Reply-To: <ZqdHpx7k6gzf-jSb@kekkonen.localdomain>
Hi Sakari
On 29/07/24 1:11 pm, Sakari Ailus wrote:
> Hi Umang,
>
> Thanks for the patch.
>
> On Mon, Jul 29, 2024 at 11:35:35AM +0530, Umang Jain wrote:
>> The imx335 reset-gpio is initialised with GPIO_OUT_LOW during probe.
> Should it be initialised to high instead, to enable reset?
This initialization matches the physical line status, which is low in
this case.
> I think you should also add a Fixes: tag to this and Cc: stable.
ack
>> However, the reset-gpio logical value is set to 1 in during power-on
>> and to 0 on power-off. This is incorrect as the reset line
>> cannot be high during power-on and low during power-off.
>>
>> Rectify the logical value of reset-gpio so that it is set to
>> 0 during power-on and to 1 during power-off.
>>
>> Signed-off-by: Umang Jain<umang.jain@ideasonboard.com>
next prev parent reply other threads:[~2024-07-29 8:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 6:05 Umang Jain
2024-07-29 7:41 ` Sakari Ailus
2024-07-29 8:49 ` Umang Jain [this message]
2024-07-29 8:54 ` Sakari Ailus
2024-07-29 10:22 ` Kieran Bingham
2024-07-29 8:12 ` Jacopo Mondi
2024-07-29 8:48 ` Umang Jain
2024-07-29 9:19 ` Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dc31ed8-ad83-4051-8de3-6efaf1538714@ideasonboard.com \
--to=umang.jain@ideasonboard.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®