mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Umang Jain <umang.jain@ideasonboard.com>
Cc: linux-media@vger.kernel.org,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	open list <linux-kernel@vger.kernel.org>,
	Tommaso Merciai <tomm.merciai@gmail.com>
Subject: Re: [PATCH] media: imx335: Fix reset-gpio handling
Date: Mon, 29 Jul 2024 07:41:27 +0000	[thread overview]
Message-ID: <ZqdHpx7k6gzf-jSb@kekkonen.localdomain> (raw)
In-Reply-To: <20240729060535.3227-1-umang.jain@ideasonboard.com>

Hi Umang,

Thanks for the patch.

On Mon, Jul 29, 2024 at 11:35:35AM +0530, Umang Jain wrote:
> The imx335 reset-gpio is initialised with GPIO_OUT_LOW during probe.

Should it be initialised to high instead, to enable reset?

I think you should also add a Fixes: tag to this and Cc: stable.

> However, the reset-gpio logical value is set to 1 in during power-on
> and to 0 on power-off. This is incorrect as the reset line
> cannot be high during power-on and low during power-off.
> 
> Rectify the logical value of reset-gpio so that it is set to
> 0 during power-on and to 1 during power-off.
> 
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>

-- 
Kind regards,

Sakari Ailus

  reply	other threads:[~2024-07-29  7:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-29  6:05 Umang Jain
2024-07-29  7:41 ` Sakari Ailus [this message]
2024-07-29  8:49   ` Umang Jain
2024-07-29  8:54     ` Sakari Ailus
2024-07-29 10:22       ` Kieran Bingham
2024-07-29  8:12 ` Jacopo Mondi
2024-07-29  8:48   ` Umang Jain
2024-07-29  9:19     ` Jacopo Mondi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZqdHpx7k6gzf-jSb@kekkonen.localdomain \
    --to=sakari.ailus@linux.intel.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=tomm.merciai@gmail.com \
    --cc=umang.jain@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®