From: Chi Zhiling <chizhiling@163.com>
To: Youling Tang <youling.tang@linux.dev>,
Namjae Jeon <linkinjeon@kernel.org>,
Sungjong Seo <sj1557.seo@samsung.com>
Cc: Yuezhang Mo <yuezhang.mo@sony.com>,
exfat@lists.linux.dev, linux-kernel@vger.kernel.org,
Youling Tang <tangyouling@kylinos.cn>
Subject: Re: [PATCH v2] exfat: hold s_lock for cluster-chain updates in __exfat_cont_expand()
Date: Wed, 18 Nov 2026 11:22:27 +0800 [thread overview]
Message-ID: <2df33679-680c-4fc5-a279-e0e38025f22e@163.com> (raw)
In-Reply-To: <20261118015802.899847-1-youling.tang@linux.dev>
On 11/18/26 09:58, Youling Tang wrote:
> From: Youling Tang <tangyouling@kylinos.cn>
>
> __exfat_cont_expand() allocates clusters, appends them to the FAT chain
> and updates ei->start_clu, ei->flags and i_blocks without holding
> sbi->s_lock. Readers such as writeback call exfat_map_cluster() with
> s_lock held but without inode_lock, so they are not serialized against
> the expansion and can observe the chain metadata mid-update.
>
> Hold s_lock around the cluster allocation, chain append and i_blocks
> update. This nests inside the invalidate_lock held by
> exfat_cont_expand(), matching the order used by exfat_truncate(). i_size
> is published via exfat_pagecache_isize_extended(), which takes the
> straddling folio lock; since writeback takes folio lock -> s_lock, this
> must happen after s_lock is released to avoid inverting the lock order.
> i_blocks is therefore updated first, under s_lock, which also ensures a
> reader never sees i_size beyond the allocated chain.
>
> Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
Looks good to me:
Reviewed-by: Chi Zhiling <chizhiling@kylinos.cn>
> ---
> v2: rebase onto exfat/dev and adapt to __exfat_cont_expand().
>
> fs/exfat/file.c | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/fs/exfat/file.c b/fs/exfat/file.c
> index 9dfd99ad9265..c7991e98a07a 100644
> --- a/fs/exfat/file.c
> +++ b/fs/exfat/file.c
> @@ -105,6 +105,7 @@ static int __exfat_cont_expand(struct inode *inode, loff_t size)
> if (ret)
> return ret;
>
> + mutex_lock(&sbi->s_lock);
> num_clusters = exfat_bytes_to_cluster(sbi, exfat_ondisk_size(inode));
> /* integer overflow is already checked in inode_newsize_ok(). */
> new_num_clusters = exfat_bytes_to_cluster_round_up(sbi, size);
> @@ -116,7 +117,7 @@ static int __exfat_cont_expand(struct inode *inode, loff_t size)
> exfat_chain_set(&clu, ei->start_clu, num_clusters, ei->flags);
> ret = exfat_find_last_cluster(sb, &clu, &last_clu);
> if (ret)
> - return ret;
> + goto unlock;
>
> clu.dir = last_clu + 1;
> } else {
> @@ -130,7 +131,7 @@ static int __exfat_cont_expand(struct inode *inode, loff_t size)
> ret = exfat_alloc_cluster(inode, new_num_clusters - num_clusters,
> &clu, inode_needs_sync(inode), false);
> if (ret)
> - return ret;
> + goto unlock;
>
> /* Append new clusters to chain */
> if (num_clusters) {
> @@ -147,15 +148,19 @@ static int __exfat_cont_expand(struct inode *inode, loff_t size)
> ei->flags = clu.flags;
>
> out:
> + inode->i_blocks = round_up(size, sbi->cluster_size) >> 9;
> inode_set_mtime_to_ts(inode, inode_set_ctime_current(inode));
> + mutex_unlock(&sbi->s_lock);
> +
> /*
> * When extending file size, call exfat_pagecache_isize_extended()
> * to update i_size and ensure the straddling folio is properly
> * marked RO so page_mkwrite() is called and post-EOF area is zeroed.
> + *
> + * It takes the folio lock; call it without s_lock (writeback uses
> + * folio lock -> s_lock).
> */
> exfat_pagecache_isize_extended(inode, oldsize, size);
> -
> - inode->i_blocks = round_up(size, sbi->cluster_size) >> 9;
> mark_inode_dirty(inode);
>
> if (IS_SYNC(inode))
> @@ -165,7 +170,10 @@ static int __exfat_cont_expand(struct inode *inode, loff_t size)
>
> free_clu:
> exfat_free_cluster(inode, &clu);
> - return -EIO;
> + ret = -EIO;
> +unlock:
> + mutex_unlock(&sbi->s_lock);
> + return ret;
> }
>
> static int exfat_cont_expand(struct inode *inode, loff_t size)
prev parent reply other threads:[~2026-11-18 3:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 1:58 Youling Tang
2026-11-18 3:22 ` Chi Zhiling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2df33679-680c-4fc5-a279-e0e38025f22e@163.com \
--to=chizhiling@163.com \
--cc=exfat@lists.linux.dev \
--cc=linkinjeon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=tangyouling@kylinos.cn \
--cc=youling.tang@linux.dev \
--cc=yuezhang.mo@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®